-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues encountered during pytest #166
Merged
+231
−153
Merged
Changes from 42 commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
1afacc2
Merge branch 'fastsim-3' into f3/fix-pytest-issues
11b0162
Add source dist and wheel builds; save artifacts.
229d4f0
Fix typo with quotes
4f6f2b8
Fix issue with string replacement.
9ca2e11
Go back to using just python minor version.
abd68a4
Update build_and_test file to include pytest for test_speedup.py
c5660d0
Disable speed tests without environment variable
4a913ce
Update for both x86 as well as apple silicon targets
501b2c6
Turn speedup tests off by default
3cf1bd3
Conditionally add target architecture
cee6005
Add required path to tests for cibuildwheel to work
1bdd93d
Revert to unittest suite (vs pytest)
9608026
Iterating on build settings for cibuildwheel
2f77822
Combine target names and set artifact names.
1261f67
Temporarily reduce matrix size
0573991
Reduce run matrix
c86f6db
Improve artifact names; try macos CI
3d95985
Correct syntax error in YAML
e7a99b9
Adjust settings to get CI to build MacOS X
0823398
Add back MacOS arm64
2184505
Switch to arm64
153cc5b
Set up Python to use native python for macos (Apple Silicon)
435f605
Try reverting cibuildwheel command to FS2
afc953a
Update workflow to try to get macos to build
b8a423c
Differentiate artifact names
c55a880
Run with full matrix
e3b200d
Revert to closer to fastsim-2 workflow
51bd2ef
Switch to new Github Action for rust installation
f56d144
Correct matrix variable path
1d10eab
Add os version to build string
5051c11
Adjust macos build configs for rust
5b274c2
Run only macos-14 for testing; change version from number to string
706178f
Add x86_64 for MacOS-14
8dace69
Explicitly set MacOS arch vs universal2.
6dc3c23
Include macos-13
8802214
Re-enable all os/python versions
d9238df
Update Python versions to test
a25a117
Update python versions to include 3.11
a83a9eb
Bump min version of python to range tested.
79d4ded
Set minimum MacOS deployment target for Intel mac builds
michael-okeefe cfd75ed
Merge branch 'fastsim-3' into f3/fix-pytest-issues
calbaker ef074a6
Merge branch 'fastsim-3' of github.com:NREL/fastsim into f3/fix-pytes…
calbaker 83e16d4
Add note for os matrix
michael-okeefe 9249823
Switch to use latest vs 14 for macos
michael-okeefe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michael-okeefe , could you drop some comments in here explaining why
latest
does not work formacos
and why13
and14
are used here? I want to make sure this is not hard to decipher in the future.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michael-okeefe , please also explain in the comments what event should trigger adding
15
,16
, ...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I can do that. The issue is related to what processor each github CI machine is running for mac. MacOS 13 is Intel and MacOS 14 is Apple Silicon. Ideally, the Apple transition to their new chip occurs fast and we can drop having to call out specific machines and then just use latest, etc. 15, 16, etc. can be brought in at any time we desire and they should look like the calls for 14. As soon as 13 drops from the board, we can go back to just saying 'latest'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@calbaker Note added to clarify why we are calling out macos-13 and 14.