Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update vehicle import file #128

Merged
merged 31 commits into from
Jan 17, 2025
Merged

update vehicle import file #128

merged 31 commits into from
Jan 17, 2025

Conversation

robinsteuteville
Copy link
Collaborator

This is a branch for the updated vehicle import file

robinsteuteville and others added 30 commits May 20, 2024 13:09
@robinsteuteville
update vehicle import file
9f98250
@robinsteuteville
adding id to get options for year make model function
f87d83f
@robinsteuteville
updating tests for vehicle_import file
658cabb
@robinsteuteville
updating vehicle_import file
303f792
@robinsteuteville
adding primary doc field to vehicle files
1a88294
@robinsteuteville
updating vehicle doc field
633b0aa
@robinsteuteville
moving vehicle doc addition to python side
1935be8
@robinsteuteville
troubleshooting why some vehicles are not being made
b2b5aef
@robinsteuteville
taking away added print
a7e5bc4
@robinsteuteville
updating context to with_context
e468e3f
@robinsteuteville
updating error message
24f69cb
@robinsteuteville
updating branch to keep up to date with main fastsim-2 branch
09ca705
@robinsteuteville
adding skewness_shift() function to Rust and adding get_update_skew()…
00445ab 
… function to RustVehicle, along with associated getters and setters, using pyarray
@robinsteuteville
updating pyarrays to be fixed rather than dynamic dimension
c55d388
@robinsteuteville
updating the set_mc_eff_peak_pwr() to be a setter so it can directly …
ad099b7 
…be called by set_attrs_with_path
@robinsteuteville
updating name of mc_eff_peak_pwr
bb40250
@robinsteuteville
testing new large baseline eff to see if produces better BEV results
bb04c39
@robinsteuteville
second attempt at trying new LARGE_BASELINE_EFF
cb29fb7
@robinsteuteville
changing LARGE_BASELINE_EFF back to original array
ee21c89
@robinsteuteville
updating mc_peak_eff and mc_eff_peak_pwr setters to update mc_eff_map…
dbda69f 
… and mc_eff_array
@robinsteuteville
adding set_mc_eff_range method
5f668b8
@robinsteuteville
updating error message for skewness shift
b4bfcff
@robinsteuteville
updating LARGE_BASELINE_EFF for test purposes (will change back)
9f3fd00
@robinsteuteville
returning LARGE_BASELINE_EFF to normal
fe26d38
@robinsteuteville
bringing branch in line with main fastsim-2 branch
edb1b99
@robinsteuteville
adding fc_eff_peak_pwr and fc_eff_range setters
29426a0
@kylecarow
add EPA data index to import
82847c2
@robinsteuteville
fixing small typo in vehicle_utils comments
35f1d44
@robinsteuteville
Merge branch 'update-vehicle-import' of https://github.com/NREL/fastsim…
96971b8 
… into update-vehicle-import
@robinsteuteville
merging fastsim-2 branch into this branch to bring this branch up-to-…
19b738f 
…date
@robinsteuteville robinsteuteville marked this pull request as ready for review January 16, 2025 16:39
@robinsteuteville
Copy link
Collaborator Author

@kylecarow Please look over this to make sure that non of the updates (especially to the vehicle_import.rs file itself) will be problematic.

@calbaker calbaker merged commit 651ab3f into fastsim-2 Jan 17, 2025
3 checks passed
@calbaker calbaker deleted the update-vehicle-import branch January 17, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calbaker calbaker calbaker approved these changes

@kylecarow kylecarow kylecarow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robinsteuteville @calbaker @kylecarow