Skip to content

Commit

Permalink
TODO comments
Browse files Browse the repository at this point in the history
  • Loading branch information
calbaker committed Jan 23, 2025
1 parent 37918d0 commit 20e244c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
1 change: 1 addition & 0 deletions fastsim-core/src/drive_cycle.rs
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ pub struct Cycle {
/// ambient air temperature w.r.t. to time (rather than spatial position)
#[serde(default, skip_serializing_if = "Vec::is_empty")]
pub temp_amb_air: Vec<si::Temperature>,
// TODO: add provision for optional time-varying aux load
}

lazy_static! {
Expand Down
6 changes: 6 additions & 0 deletions fastsim-core/src/vehicle/hev.rs
Original file line number Diff line number Diff line change
Expand Up @@ -595,6 +595,12 @@ impl HEVPowertrainControls {
fc_state.pwr_prop_max.get::<si::kilowatt>()
);

// # Brain dump for thermal stuff
// TODO: engine on/off w.r.t. thermal stuff should not come into play
// if there is no component (e.g. cabin) demanding heat from the engine. My 2019
// Hyundai Ioniq will turn the engine off if there is no heat demand regardless of
// the coolant temperature
// TODO: make sure idle fuel gets converted to heat correctly
let (fc_pwr, em_pwr) = match self {
Self::RGWDB(ref mut rgwdb) => {
handle_fc_on_causes_for_temp(fc, rgwdb, hev_state)?;
Expand Down

0 comments on commit 20e244c

Please sign in to comment.