ensure consistency with ewizapp code #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spodgorny9
force-pushed
the
sp/app_alignment
branch
from
35b8c6d to
800d2b3
Compare
spodgorny9
commented
Nov 8, 2024
| aws_access_key_id=access_key, | ||
| aws_secret_access_key=secret_key, | ||
| aws_session_token=session_token) | ||
| secret = os.getenv('AWS_SECRET_ACCESS_KEY') |
There was a problem hiding this comment.
The app uses SSO to access aws resources so the cloud team removed the assert statements since they were breaking the deployment. Doing it this way should preserve functionality locally and keep the deployment structure intact . Let me know what you think.
There was a problem hiding this comment.
that's fine, you could also raise a warning that would be ignored on the app
grantbuster
approved these changes
Nov 12, 2024
| aws_access_key_id=access_key, | ||
| aws_secret_access_key=secret_key, | ||
| aws_session_token=session_token) | ||
| secret = os.getenv('AWS_SECRET_ACCESS_KEY') |
There was a problem hiding this comment.
that's fine, you could also raise a warning that would be ignored on the app
github-actions bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
ensure consistency with ewizapp code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.