Remove eagle related code and reference since eagle is retired. #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmerket
approved these changes
Nov 6, 2024
Comment on lines
-8
to
+9
| eagle: include('hpc-spec', required=False) | ||
| kestrel: include('hpc-spec', required=False) | ||
| eagle: include('hpc-spec', required=False) |
There was a problem hiding this comment.
It just seems like you moved this. Shouldn't it be removed?
There was a problem hiding this comment.
Ah okay, a new schema without eagle.
Comment on lines
+63
to
+65
| the ``bundle`` and ``bundle_path`` options in the OpenStudio CLI. | ||
| See `run_building <https://github.com/NREL/buildstockbatch/blob/61c00cc4139769939f16db9b62f3a7dc58f1f46e/buildstockbatch/eagle.py#L334>`_ | ||
| for additional implementation details. |
There was a problem hiding this comment.
Makes sense to pin it to a specific commit.
Yes, I will add that to the migration guide. I will add that text to the PR description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #470.
Pull Request Description
Remove all eagle related code and references since Eagle is already retired from NREL HPC.
Migration guide:
The following changes are necessary on the yaml file after this PR is merged:
Change schema version to 0.5.
Change eagle block to kestrel block. The specification is the same, so no changes are needed for the arguments in the block.
Checklist
Not all may apply
minimum_coveragein.github/workflows/coverage.ymlas necessary.