-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes temp directory and bigmem issues with kestrel runs #438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The real solution may be to get HPC to change the file permissions on /tmp/scratch, but this works in the meantime. @rHorsey suggested doing this via ENV in the kestrel shell scripts because then it doesn't affect Eagle.
Minimum allowed coverage is Generated by 🐒 cobertura-action against 1748ec9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Add and entry to the changelog and I'll merge it when you're ready.
Updates postprocessing memory default to require less than the 250,000 MB of memory available on the standard partition nodes because Kestrel only has 8 bigmem nodes.
Specify memory for sampling and simulation jobs to avoid issue with default jobs going into bigmem queue
Are we feeling like this is ready to merge? I'd like to get this into a release so people can benefit from these bugfixes. |
@nmerket yeah, it's good to go, we used it for the Com EUSS runs |
Fixes # .
Pull Request Description
This fixes Kestrel run errors related the existing files in the common temp directory on local node storage. Eagle assumes there is always local storage, and sets the TMPDIR to /tmp/scratch/$USER. Kestrel always assumes there is no local disk, and sets TMPDIR to /tmp/scratch. Existing files from other users on /tmp/scratch cause buildstock batch to fail.
This fix ensures the temporary directory is set to /tmp/scratch/$USER, avoiding file conflicts.
Checklist
Not all may apply
Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts)minimum_coverage
in.github/workflows/coverage.yml
as necessary.Update validation for project config yaml file changes