-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move more shared code into DockerBatchBase #422
Conversation
Minimum allowed coverage is Generated by 🐒 cobertura-action against d826e51 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me too. Like I said in the other PR, I'd prefer having something in the changelog to track these changes.
Sure - just added an update to changelog_dev.rst. |
def run_simulations(cls, cfg, job_id, jobs_d, sim_dir, fs, bucket, prefix): | ||
def run_simulations(cls, cfg, job_id, jobs_d, sim_dir, fs, output_path): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this too. I kind of wish I had done this everywhere and then parsed bucket and prefix out as needed.
Pull Request Description
Moves two more sections of code into the parent class to be shared by the AWS and GCP implementations, and adds tests for them. Both are part of the tasks on the cloud that run the building simulations.
get_epws_to_download
determines which weather files are needed by a particular batch of simulations.run_simulations
runs Openstudio, writes the results to the output bucket, and cleans up any intermediate files.This is purely refactoring and does not change any behavior.
Checklist
Not all may apply
minimum_coverage
in.github/workflows/coverage.yml
as necessary.Update validation for project config yaml file changesUpdate existing documentationRun a small batch run on Kestrel/Eagle to make sure it all works if you made changes that will affect Kestrel/Eagle