Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Bug Fixes #376

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Various Bug Fixes #376

wants to merge 5 commits into from

Conversation

dzalkind
Copy link
Collaborator

@dzalkind dzalkind commented Sep 5, 2024

Description and Purpose

Collecting some outstanding bug fixes before we publish a release.

#334
#316

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

TODO Items General:

  • Add example/test for new feature
  • Update registry
  • Run testing

TODO Items API Change:

  • Update docs with API change
  • Run update_rosco_discons.py in Test_Cases/
  • Update DISCON schema

Github issues addressed, if one exists

Examples/Testing, if applicable

dzalkind and others added 5 commits August 9, 2024 10:49
* Fix GenEff when CompServo is 0

* Increment version
GB efficiency reduces LSS to HSS
GEN reduces HSS to generator electrical output
We apply the GenTq at the HSS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant