#5145 - HeatExchangerAirToAirSensibleAndLatent normalization divisor error #5193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding to a zero divisor
jmarrec
added
component - Model
Pull Request - Ready for CI
jmarrec
commented
May 13, 2024
Comment on lines
+169
to
+175
| bool TableLookup_Impl::setNormalizationDivisor(double normalizationDivisor) { | ||
| if (std::abs(normalizationDivisor) < std::numeric_limits<double>::min()) { | ||
| LOG(Warn, "Unable to set " << briefDescription() << "'s Normalization divisor to zero."); | ||
| return false; | ||
| } | ||
|
|
||
| bool result = setDouble(OS_Table_LookupFields::NormalizationDivisor, normalizationDivisor); |
There was a problem hiding this comment.
TableLookup will reject 0.0 now, and return false + a warn
Comment on lines
+1031
to
+1037
| const auto val100 = sensibleEffectivenessat100HeatingAirFlow(); | ||
| if (std::abs(val100) < std::numeric_limits<double>::min()) { | ||
| LOG_AND_THROW("Unable to set " << briefDescription() | ||
| << "'s Sensible Effectiveness at 75 Heating Air Flow because the value at 100 is zero and would lead to a " | ||
| "Normalization divisor equal to zero."); | ||
| } | ||
| auto tableLookup = makeTable(sensibleEffectivenessat75HeatingAirFlow, val100, model(), fmt::format("{}_SensHeatEff", nameString())); |
There was a problem hiding this comment.
HX: we actually throw if we get to such a condition.
Comment on lines
+405
to
+423
| // Ensure we protect users against dumb issues that lead to a normalization divisor of zero | ||
| { | ||
| // Ensure no curves assigned for now | ||
| hx.resetSensibleEffectivenessofHeatingAirFlowCurve(); | ||
| hx.resetLatentEffectivenessofHeatingAirFlowCurve(); | ||
| hx.resetSensibleEffectivenessofCoolingAirFlowCurve(); | ||
| hx.resetLatentEffectivenessofCoolingAirFlowCurve(); | ||
|
|
||
| // IMHO this doesn't make sense (IDD should be `\minimum> 0.0`), but the E+ IDD and OS IDD have always allowed it, so leaving it untouched | ||
| EXPECT_TRUE(hx.setSensibleEffectivenessat100HeatingAirFlow(0.0)); | ||
| EXPECT_TRUE(hx.setLatentEffectivenessat100HeatingAirFlow(0.0)); | ||
| EXPECT_TRUE(hx.setSensibleEffectivenessat100CoolingAirFlow(0.0)); | ||
| EXPECT_TRUE(hx.setLatentEffectivenessat100CoolingAirFlow(0.0)); | ||
|
|
||
| EXPECT_ANY_THROW(hx.setSensibleEffectivenessat75HeatingAirFlow(0.5)); | ||
| EXPECT_ANY_THROW(hx.setLatentEffectivenessat75HeatingAirFlow(0.5)); | ||
| EXPECT_ANY_THROW(hx.setSensibleEffectivenessat75CoolingAirFlow(0.5)); | ||
| EXPECT_ANY_THROW(hx.setLatentEffectivenessat75CoolingAirFlow(0.5)); | ||
| } |
There was a problem hiding this comment.
Test that it throws with HX
Comment on lines
+54
to
+56
| // #5145 - We reject 0 as a normalization divisor | ||
| EXPECT_FALSE(tableLookup.setNormalizationDivisor(0.0)); | ||
| EXPECT_EQ(0.5, tableLookup.normalizationDivisor()); |
There was a problem hiding this comment.
Test that TableLookup just returns false and leaves it untouched
jmarrec
changed the title
|
CI Results for 1b8f688:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.