Fix #5178 - Init the RUBY_DESCRIPTION properly #5179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarrec
added
component - CLI
Pull Request - Ready for CI
jmarrec
force-pushed
the
5178_RUBY_DESCRIPTION
branch
from
f6daad1 to
8154024
Compare
jmarrec
commented
May 2, 2024
Comment on lines
+17
to
+19
| struct ruby_cmdline_options; | ||
| typedef struct ruby_cmdline_options ruby_cmdline_options_t; | ||
| void Init_ruby_description(ruby_cmdline_options_t*); |
There was a problem hiding this comment.
Forward declare.
In 2.7.2, it was simpler, just void Init_ruby_description(void)
| @@ -22,6 +25,8 @@ void RubyEngine::initRubyEngine() { | |||
| RUBY_INIT_STACK; | |||
| ruby_init(); | |||
|
|
|||
| Init_ruby_description(nullptr); | |||
There was a problem hiding this comment.
Use it.
We don't just MJIT or YJIT, so it just doesn't use the param ruby_cmdline_options_t *opt anyways.
See https://github.com/ruby/ruby/blob/e51014f9c05aa65cbf203442d37fef7c12390015/version.c#L129-L162
Comment on lines
+8
to
+13
| class ConstantsTest < Minitest::Test | ||
|
|
||
| # Note: putting all of these tests under the same one because of the way we | ||
| # run the tests with the CLI (we run a CLI instance for each individual test, | ||
| # and it takes almost 20 seconds for each which is ridiculous) | ||
| def test_ruby_constants |
There was a problem hiding this comment.
new test. Grouping everything under a single minitest because it is WWAAAAAY to slow otherwise with the CLI.
Comment on lines
+17
to
+18
| refute_empty(RUBY_DESCRIPTION) | ||
| assert_match(/ruby 3.2.2 \(.*\) \[.*\]/, RUBY_DESCRIPTION) |
There was a problem hiding this comment.
Before fix
Run options: --seed 12379
# Running:
E
Finished in 0.001386s, 721.3269 runs/s, 721.3269 assertions/s.
1) Error:
ConstantsTest#test_ruby_constants:
NameError: uninitialized constant ConstantsTest::RUBY_DESCRIPTION
eval:414:in `const_missing'
/home/julien/Software/Others/OpenStudio/ruby/test/Constants_Test.rb:17:in `test_ruby_constants'
1 runs, 1 assertions, 0 failures, 1 errors, 0 skips
Comment on lines
+644
to
+647
| boost::optional<int> month_ = getInt(OS_SizingPeriod_DesignDayFields::Month); | ||
| if (month_ && (*month_ == 2)) { | ||
| boost::optional<int> day_ = this->getInt(OS_SizingPeriod_DesignDayFields::DayofMonth); | ||
| if (day_ && (*day_ == 29)) { |
There was a problem hiding this comment.
Unrelated, but fix cppcheck workflow that has been failing for some time
|
CI Results for 8154024:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.