-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IRB Debug Init + byebug #5165
IRB Debug Init + byebug #5165
Conversation
@jmarrec. This would be very useful for the kind of issues we just worked through with bundler. I'm sure that was part of the inspiration. What would be the downside of merging this? It seems like a win/win. |
Downsides include:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmarrec I just made a new release of openstudio-gems on the NREL repo. Would you mind updating the references to point at the NREL release?
Will do |
…g.irb anywhere in the code, including our own initialization
@@ -835,7 +835,7 @@ if(BUILD_CLI) | |||
set(OPENSTUDIO_GEMS_BASEURL "http://openstudio-resources.s3.amazonaws.com/dependencies") | |||
|
|||
# TODO: temp | |||
set(OPENSTUDIO_GEMS_BASEURL "https://github.com/NREL/openstudio-gems/releases/download/v3.8.0-RC1-5") | |||
set(OPENSTUDIO_GEMS_BASEURL "https://github.com/NREL/openstudio-gems/releases/download/v3.8.0-RC1-6") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kbenne done
Pull request overview
This PR does two things:
binding.irb
anywhere and it'll work. That includes inside our gem initialization code, but will work in any external script too. This allows you to inspect variables, but you don't have frame execution, because "debug" gem is built shared actually... see Bundled gems by default: debug and rbs aren't built statically jmarrec/conan-recipes#6require 'byebug'
and putbyebug
and this will allow you to have frame execution, see this examplePull Request Author
src/model/test
)src/energyplus/Test
)src/osversion/VersionTranslator.cpp
)Labels:
IDDChange
APIChange
Pull Request - Ready for CI
so that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.