CSharp Fixes for 3.7.0 release #5049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarrec
commented
Nov 20, 2023
| @@ -683,7 +683,7 @@ elseif(WIN32) | |||
| else() | |||
| set(ENERGYPLUS_PATH "EnergyPlus-${ENERGYPLUS_VERSION}-${ENERGYPLUS_BUILD_SHA}-Windows-i386") | |||
| set(ENERGYPLUS_ARCH 32) | |||
| set(ENERGYPLUS_EXPECTED_HASH TODO_TDB_TODO) # TODO: not posted on the release page yet | |||
| set(ENERGYPLUS_EXPECTED_HASH 379929e4c46e3d22d79f37b905e56a0e) | |||
There was a problem hiding this comment.
Actual change is here
jmarrec
commented
Nov 20, 2023
.github/workflows/buildCSharp.yml
Outdated
Comment on lines
32
to
41
| - uses: actions/checkout@v4 | ||
| # If you need to rebuild for a specific branch **after** you fixed the workflow... | ||
| # with: | ||
| # ref: master | ||
| with: | ||
| ref: develop | ||
|
|
||
| - name: download patched CMakeLists.txt | ||
| shell: bash | ||
| run: | | ||
| rm CMakeLists.txt | ||
| aria2c https://raw.githubusercontent.com/NREL/OpenStudio/CSharp/CMakeLists.txt |
There was a problem hiding this comment.
- TODO: revert 28f2747
|
@MingboPeng The 3.7.0 c# packages are on this run: https://github.com/NREL/OpenStudio/actions/runs/6927494494/job/18841460741?pr=5049 |
…akelists (E+ x86 sha)" This reverts commit 28f2747.
MingboPeng
added a commit
to MingboPeng/OpenStudio.Nuget.Publisher
that referenced
this pull request
Nov 20, 2023
|
Thanks @jmarrec for letting me know. New 3.7.0 NuGet packages are published. https://www.nuget.org/packages/NREL.OpenStudio.win |
60 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.