Fix #4831 - Platform dependent results for joinAll

[jmarrec]

Pull request overview

• Fixes Daylight sensor placement difference between Windows and Linux #4831

Pull Request Author

• Model API Changes / Additions
• Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• Model API methods are tested (in src/model/test)
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
• If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes
• If methods have been deprecated, update rest of code to use the new methods

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[jmarrec]

RemoteBCL is failing on Unix, but otherwise test pass. Windows has the stability error

[ RUN      ] GeometryFixture.Intersection_Stability
[utilities.geometry.join] <1> Union has inner loops
D:\git\OpenStudio\src\utilities\geometry\Test\Intersection_GTest.cpp(2678): error: Value of: sink.logMessages().empty()
  Actual: false
Expected: true

[ci-commercialbuildings]

CI Results for 62cc188:

• Ubuntu 20.04:

• Ubuntu 22.04:

• Darwin:

  • OpenStudio-3.6.0-alpha+62cc188a6a-Darwin-x86_64.dmg
  • OpenStudio-3.6.0-alpha+62cc188a6a-Darwin-x86_64.tar.gz

• Windows:

• Code Coverage:

[ci-commercialbuildings]

CI Results for 62cc188:

• Ubuntu 20.04:

  • OpenStudio-3.6.0-alpha+62cc188a6a-Ubuntu-20.04-x86_64.deb
  • OpenStudio-3.6.0-alpha+62cc188a6a-Ubuntu-20.04-x86_64.tar.gz
  • perf_test/results.html

• Ubuntu 22.04:

• Darwin:

• Windows:

  • OpenStudio-3.6.0-alpha+62cc188a6a-Windows.exe
  • OpenStudio-3.6.0-alpha+62cc188a6a-Windows.tar.gz

• Code Coverage:

[jmarrec]

@mdahlhausen could you test this out please?

[mdahlhausen]

@jmarrec can do

[mdahlhausen]

@jmarrec, @tijcolem tested - I'm getting the same results now between windows and linux. Thanks!

[jmarrec]

@jmarrec, @tijcolem tested - I'm getting the same results now between windows and linux. Thanks!

Thanks for confirming @mdahlhausen !

(You should revisit whether your workaround in space_join_polygons is still needed)

[jmarrec]

@mdahlhausen To clarify, now that I'm back at a computer, I think the issue you were trying to work around might have been #1614 which has been fixed by #4221