Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4046 - Clarify the situation with output file in the ReportingMeasure Template #4345

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Jun 3, 2021

Pull request overview

#4046 - Clarify the situation with output file in the ReportingMeasure Template

In conjunction with NREL/OpenStudio-user-documentation#25

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@jmarrec jmarrec self-assigned this Jun 3, 2021
@jmarrec
Copy link
Collaborator Author

jmarrec commented Jun 9, 2021

@DavidGoldwasser Could you check the related PR on NREL/OpenStudio-user-documentation#25 or tell me who I should ping to get it reviewed please?

@tijcolem tijcolem added this to the OpenStudio SDK 3.3.0 milestone Jun 11, 2021
@tijcolem tijcolem merged commit b0677c3 into develop Jun 21, 2021
@jmarrec jmarrec deleted the 4046_ScheduleFile_Measure branch March 25, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants