-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4336 - Encode searchTerm in BCL (including spaces, not only "+" signs) #4337
Conversation
src/utilities/bcl/RemoteBCL.cpp
Outdated
// web::uri::encode_data_string will Encodes a string by converting all characters | ||
// except for RFC 3986 unreserved characters to their hexadecimal representation. (eg: '+' => %2B, ' ' => %20) | ||
auto query = searchTerm.empty() ? "*" : web::uri::encode_data_string(searchTerm); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same change as this one repeated.
set(CMAKE_CONAN_EXPECTED_HASH 170c3250029af321395135a3952a9045) | ||
set(CMAKE_CONAN_VERSION "v0.16.1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump conan.cmake
7c684bd
to
3ce0b2f
Compare
CI Results for 0882594:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for making windows happy =)
Pull request overview
Fix #4336 - Encode searchTerm in BCL (including spaces, not only "+" signs)
The Cpprestsdk documentation is not great (and I couldn't find any post on stackoverflow), but I found a function that does just what's expected.
https://microsoft.github.io/cpprestsdk/classweb_1_1uri.html#ac1a92ee41ad0e77e262a8b4fcb235ac1
Also bumped the conan.cmake to v0.16.1
Pull Request Author
src/model/test
)src/energyplus/Test
)src/osversion/VersionTranslator.cpp
)Labels:
IDDChange
APIChange
Pull Request - Ready for CI
so that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.