Fix #4331 - Fix StringHelpers openstudio::replace

[jmarrec]

Pull request overview

Fix #4331 - Fix StringHelpers openstudio::replace

( Fix openstudiocoalition/OpenStudioApplication#332 as well )

I replaced it with boost::replace_all (which in this case acts exactly like boost::replace_all_copy since we take input by value (copy)), since it's considerably faster on larger strings (which is our case since we mostly use it for replacing inside ruby file contents), cf benchmark I wrote on my repo here: jmarrec/CppBenchmarks@c91dbd9

Pull Request Author

• Model API Changes / Additions
• Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• Model API methods are tested (in src/model/test)
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
• If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes
• If methods have been deprecated, update rest of code to use the new methods

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[ci-commercialbuildings]

CI Results for e4d19e7:

• Ubuntu 18.04:

  • OpenStudio-3.2.1-alpha+e4d19e7aa7-Ubuntu-18.04.deb
  • OpenStudio-3.2.1-alpha+e4d19e7aa7-Ubuntu-18.04.tar.gz

• Ubuntu 20.04:

• Darwin:

  • OpenStudio-3.2.1-alpha+e4d19e7aa7-Darwin.dmg
  • OpenStudio-3.2.1-alpha+e4d19e7aa7-Darwin.tar.gz

• Windows:

  • OpenStudio-3.2.1-alpha+e4d19e7aa7-Windows.exe
  • OpenStudio-3.2.1-alpha+e4d19e7aa7-Windows.tar.gz

[tijcolem]

Looks good to me. Any performance gain such as this is welcome. I did a sanity test and ran the regression test suite as well (https://github.com/NREL/OpenStudio-resources/runs/2697133178?check_suite_focus=true) and all checked out good.