Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses #4183 and #4231, provide OS SDK/API support for the EnergyPlus "CoilSystem:IntegratedHeatPump:AirSource" and "Coil:WaterHeating:AirToWaterHeatPump:VariableSpeed" objects #4236

Merged
merged 36 commits into from
Mar 25, 2021
Merged
Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
0c94707
Add coil system ihp to idd.
joseph-robertson Mar 8, 2021
c43bef9
Add coil system ihp to model.
joseph-robertson Mar 8, 2021
36f19c0
Add coil system ihp to ft.
joseph-robertson Mar 8, 2021
36311a1
Add coil wh var speed to idd.
joseph-robertson Mar 9, 2021
de3b05d
Update model for coil wh var speed.
joseph-robertson Mar 9, 2021
55d5725
Update ft for coil wh var speed.
joseph-robertson Mar 9, 2021
6c807a7
Merge branch 'develop' into issue-4183
joseph-robertson Mar 9, 2021
de0e425
Remove extra methods from coil wh var speed.
joseph-robertson Mar 9, 2021
c7bbac0
Make part load curve required on coil wh var speed.
joseph-robertson Mar 9, 2021
52aa7d5
Typo in part load fraction setter.
joseph-robertson Mar 10, 2021
f6271e3
Missed a required field in idd.
joseph-robertson Mar 10, 2021
4ef05c2
Update ctor value on coil wh var speed.
joseph-robertson Mar 10, 2021
891d1eb
Update ctor value on coil wh var speed speed data.
joseph-robertson Mar 10, 2021
d391fc5
Update speed data ctor and tests.
joseph-robertson Mar 10, 2021
ec97b0c
Make all children coils of CoilSystemIntegratedHeatPumpAirSource requ…
jmarrec Mar 11, 2021
171f217
Add missing method: CoilWaterHeatingAirToWaterHeatPumpVariableSpeed_I…
jmarrec Mar 11, 2021
7180d25
Add OutputVariables
jmarrec Mar 11, 2021
e2e41ca
Adjust Gtest. The Remove() one is failing, because the childrne coils…
jmarrec Mar 11, 2021
602ffd0
There isn't an easy way to deal with the test failure, so I'm changin…
jmarrec Mar 11, 2021
31ffa67
clang-format [chore]
jmarrec Mar 11, 2021
69c8276
Merge branch 'develop' into issue-4183
joseph-robertson Mar 11, 2021
8254a17
Merge branch 'issue-4183' of github.com:NREL/OpenStudio into issue-4183
joseph-robertson Mar 11, 2021
d4b35c2
Add alternative ctor with default coils.
joseph-robertson Mar 11, 2021
3c7bc4f
Clean up and add test for default ctor.
joseph-robertson Mar 12, 2021
bae271d
Update ctor values and tests.
joseph-robertson Mar 16, 2021
8a15e3b
Merge branch 'develop' into issue-4183
joseph-robertson Mar 16, 2021
9e83604
Merge branch 'develop' into issue-4183
joseph-robertson Mar 23, 2021
3e01503
FT: translate Coil only if it has speeds
jmarrec Mar 24, 2021
503a590
Add outputVariableNames, remove getScheduleTypeKeys for class without…
jmarrec Mar 24, 2021
7cc7955
Adjust FT test to actually add Speeds to the CoilWaterHeatingAirToWat…
jmarrec Mar 24, 2021
7c9bcdc
Add test for CoilSystemIntegratedHeatPumpAirSource::containingHVACCom…
jmarrec Mar 24, 2021
12e1a52
CoilSystemIntegratedHeatPumpAirSource::containingHVACComponent: inclu…
jmarrec Mar 24, 2021
1ca2384
Remove the Grid Signal stuff in ScheduleTypeRegistry
jmarrec Mar 24, 2021
0091ee3
Add test for CoilWaterHeatingAirToWaterHeatPumpVariableSpeedSpeedData…
jmarrec Mar 24, 2021
501a283
Add tests for CoilWaterHeatingAirToWaterHeatPumpVariableSpeed::contai…
jmarrec Mar 24, 2021
f040990
Test what happens to SpeedData / ModelObjectList when cloning CoilWat…
jmarrec Mar 24, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions resources/energyplus/ProposedEnergy+.idd
Original file line number Diff line number Diff line change
Expand Up @@ -33232,6 +33232,7 @@ Coil:WaterHeating:AirToWaterHeatPump:VariableSpeed,
\note heating COP curves. This input determines whether
\note the inlet air dry-bulb or wet-bulb temperature is used to evaluate these curves.
A10, \field Part Load Fraction Correlation Curve Name
\required-field
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\type object-list
\object-list UnivariateFunctions
\note Table:Lookup object can also be used
Expand Down Expand Up @@ -33678,67 +33679,68 @@ CoilSystem:Cooling:DX:HeatExchangerAssisted,
\object-list CoolingCoilsDXVariableSpeed

CoilSystem:IntegratedHeatPump:AirSource,
\memo This object is used for air-source integrated heat pump, a collection of its working modes.
A1, \field Name
\memo This object is used for air-source integrated heat pump, a collection of its working modes.
A1, \field Name
\required-field
\type alpha
\reference IntegratedHeatPumps
\note Unique name for this instance of an air-source integrated heat pump.
A2, \field Supply Hot Water Flow Sensor Node Name
A2, \field Supply Hot Water Flow Sensor Node Name
\required-field
\type node
A3, \field Space Cooling Coil Name
A3, \field Space Cooling Coil Name
\required-field
\type object-list
\object-list CoolingCoilsDXVariableSpeed
\note Must match the name used in the corresponding Coil:Cooling:DX:VariableSpeed object.
A4, \field Space Heating Coil Name
A4, \field Space Heating Coil Name
\required-field
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\type object-list
\object-list HeatingCoilsDXVariableSpeed
\note Must match the name used in the corresponding Coil:Heating:DX:VariableSpeed object.
A5, \field Dedicated Water Heating Coil Name
A5, \field Dedicated Water Heating Coil Name
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\type object-list
\object-list HeatPumpWaterHeaterDXCoilsVariableSpeed
\note Must match the name used in the corresponding Coil:WaterHeating:AirToWaterHeatPump:VariableSpeed object.
A6, \field SCWH Coil Name
A6, \field SCWH Coil Name
\type object-list
\object-list HeatPumpWaterHeaterDXCoilsVariableSpeed
\note Must match the name used in the corresponding Coil:WaterHeating:AirToWaterHeatPump:VariableSpeed object.
A7, \field SCDWH Cooling Coil Name
A7, \field SCDWH Cooling Coil Name
\type object-list
\object-list CoolingCoilsDXVariableSpeed
\note Must match the name used in the corresponding Coil:Cooling:DX:VariableSpeed object.
A8, \field SCDWH Water Heating Coil Name
A8, \field SCDWH Water Heating Coil Name
\type object-list
\object-list HeatPumpWaterHeaterDXCoilsVariableSpeed
\note Must match the name used in the corresponding Coil:WaterHeating:AirToWaterHeatPump:VariableSpeed object.
A9, \field SHDWH Heating Coil Name
A9, \field SHDWH Heating Coil Name
\type object-list
\object-list HeatingCoilsDXVariableSpeed
\note Must match the name used in the corresponding Coil:Heating:DX:VariableSpeed object.
A10, \field SHDWH Water Heating Coil Name
\type object-list
\object-list HeatPumpWaterHeaterDXCoilsVariableSpeed
\note Must match the name used in the corresponding Coil:WaterHeating:AirToWaterHeatPump:VariableSpeed object.
N1 , \field Indoor Temperature Limit for SCWH Mode
N1, \field Indoor Temperature Limit for SCWH Mode
\type real
\units C
\minimum> 15.0
\default 20.0
\note Indoor Temperature above which Indoor Overcooling is Allowed during Cooling Operation
N2 , \field Ambient Temperature Limit for SCWH Mode
N2, \field Ambient Temperature Limit for SCWH Mode
\type real
\units C
\minimum> 20.0
\default 27.0
\note Ambient Temperature above which Indoor Overcooling is Allowed during Cooling Operation
N3 , \field Indoor Temperature above Which WH has Higher Priority
N3, \field Indoor Temperature above Which WH has Higher Priority
\type real
\units C
\minimum> 15.0
\default 20.0
\note Indoor Temperature above which Water Heating has the higher priority and Space Heating Call Can be ignored.
N4 , \field Ambient Temperature above Which WH has Higher Priority
N4, \field Ambient Temperature above Which WH has Higher Priority
\type real
\units C
\minimum> 15.0
Expand All @@ -33755,7 +33757,7 @@ CoilSystem:IntegratedHeatPump:AirSource,
\default 1
\minimum> 0
\maximum< 10
N7 , \field Maximum Water Flow Volume before Switching from SCDWH to SCWH Mode
N7, \field Maximum Water Flow Volume before Switching from SCDWH to SCWH Mode
\type real
\units m3
\default 0.0
Expand All @@ -33777,8 +33779,6 @@ CoilSystem:IntegratedHeatPump:AirSource,
\minimum> 0
\maximum< 10



Coil:Cooling:DX:SingleSpeed:ThermalStorage,
\memo Direct expansion (DX) cooling coil and condensing unit (includes electric compressor
\memo and condenser fan), single-speed with packaged integrated thermal storage for cooling.
Expand Down
Loading