-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addresses #4183 and #4231, provide OS SDK/API support for the EnergyPlus "CoilSystem:IntegratedHeatPump:AirSource" and "Coil:WaterHeating:AirToWaterHeatPump:VariableSpeed" objects #4236
Changes from 14 commits
0c94707
c43bef9
36f19c0
36311a1
de3b05d
55d5725
6c807a7
de0e425
c7bbac0
52aa7d5
f6271e3
4ef05c2
891d1eb
d391fc5
ec97b0c
171f217
7180d25
e2e41ca
602ffd0
31ffa67
69c8276
8254a17
d4b35c2
3c7bc4f
bae271d
8a15e3b
9e83604
3e01503
503a590
7cc7955
7c9bcdc
12e1a52
1ca2384
0091ee3
501a283
f040990
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33232,6 +33232,7 @@ Coil:WaterHeating:AirToWaterHeatPump:VariableSpeed, | |
\note heating COP curves. This input determines whether | ||
\note the inlet air dry-bulb or wet-bulb temperature is used to evaluate these curves. | ||
A10, \field Part Load Fraction Correlation Curve Name | ||
\required-field | ||
\type object-list | ||
\object-list UnivariateFunctions | ||
\note Table:Lookup object can also be used | ||
|
@@ -33678,67 +33679,68 @@ CoilSystem:Cooling:DX:HeatExchangerAssisted, | |
\object-list CoolingCoilsDXVariableSpeed | ||
|
||
CoilSystem:IntegratedHeatPump:AirSource, | ||
\memo This object is used for air-source integrated heat pump, a collection of its working modes. | ||
A1, \field Name | ||
\memo This object is used for air-source integrated heat pump, a collection of its working modes. | ||
A1, \field Name | ||
\required-field | ||
\type alpha | ||
\reference IntegratedHeatPumps | ||
\note Unique name for this instance of an air-source integrated heat pump. | ||
A2, \field Supply Hot Water Flow Sensor Node Name | ||
A2, \field Supply Hot Water Flow Sensor Node Name | ||
\required-field | ||
\type node | ||
A3, \field Space Cooling Coil Name | ||
A3, \field Space Cooling Coil Name | ||
\required-field | ||
\type object-list | ||
\object-list CoolingCoilsDXVariableSpeed | ||
\note Must match the name used in the corresponding Coil:Cooling:DX:VariableSpeed object. | ||
A4, \field Space Heating Coil Name | ||
A4, \field Space Heating Coil Name | ||
\required-field | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think I agree it's a required-field: https://github.com/NREL/EnergyPlus/blob/93421b9a9d4eb1656e7fa123ded715504d107051/src/EnergyPlus/IntegratedHeatPump.cc#L1197-L1213 |
||
\type object-list | ||
\object-list HeatingCoilsDXVariableSpeed | ||
\note Must match the name used in the corresponding Coil:Heating:DX:VariableSpeed object. | ||
A5, \field Dedicated Water Heating Coil Name | ||
A5, \field Dedicated Water Heating Coil Name | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This one, and all other coils below should be \required-field too I think. https://github.com/NREL/EnergyPlus/blob/93421b9a9d4eb1656e7fa123ded715504d107051/src/EnergyPlus/IntegratedHeatPump.cc#L1215-L1231 |
||
\type object-list | ||
\object-list HeatPumpWaterHeaterDXCoilsVariableSpeed | ||
\note Must match the name used in the corresponding Coil:WaterHeating:AirToWaterHeatPump:VariableSpeed object. | ||
A6, \field SCWH Coil Name | ||
A6, \field SCWH Coil Name | ||
\type object-list | ||
\object-list HeatPumpWaterHeaterDXCoilsVariableSpeed | ||
\note Must match the name used in the corresponding Coil:WaterHeating:AirToWaterHeatPump:VariableSpeed object. | ||
A7, \field SCDWH Cooling Coil Name | ||
A7, \field SCDWH Cooling Coil Name | ||
\type object-list | ||
\object-list CoolingCoilsDXVariableSpeed | ||
\note Must match the name used in the corresponding Coil:Cooling:DX:VariableSpeed object. | ||
A8, \field SCDWH Water Heating Coil Name | ||
A8, \field SCDWH Water Heating Coil Name | ||
\type object-list | ||
\object-list HeatPumpWaterHeaterDXCoilsVariableSpeed | ||
\note Must match the name used in the corresponding Coil:WaterHeating:AirToWaterHeatPump:VariableSpeed object. | ||
A9, \field SHDWH Heating Coil Name | ||
A9, \field SHDWH Heating Coil Name | ||
\type object-list | ||
\object-list HeatingCoilsDXVariableSpeed | ||
\note Must match the name used in the corresponding Coil:Heating:DX:VariableSpeed object. | ||
A10, \field SHDWH Water Heating Coil Name | ||
\type object-list | ||
\object-list HeatPumpWaterHeaterDXCoilsVariableSpeed | ||
\note Must match the name used in the corresponding Coil:WaterHeating:AirToWaterHeatPump:VariableSpeed object. | ||
N1 , \field Indoor Temperature Limit for SCWH Mode | ||
N1, \field Indoor Temperature Limit for SCWH Mode | ||
\type real | ||
\units C | ||
\minimum> 15.0 | ||
\default 20.0 | ||
\note Indoor Temperature above which Indoor Overcooling is Allowed during Cooling Operation | ||
N2 , \field Ambient Temperature Limit for SCWH Mode | ||
N2, \field Ambient Temperature Limit for SCWH Mode | ||
\type real | ||
\units C | ||
\minimum> 20.0 | ||
\default 27.0 | ||
\note Ambient Temperature above which Indoor Overcooling is Allowed during Cooling Operation | ||
N3 , \field Indoor Temperature above Which WH has Higher Priority | ||
N3, \field Indoor Temperature above Which WH has Higher Priority | ||
\type real | ||
\units C | ||
\minimum> 15.0 | ||
\default 20.0 | ||
\note Indoor Temperature above which Water Heating has the higher priority and Space Heating Call Can be ignored. | ||
N4 , \field Ambient Temperature above Which WH has Higher Priority | ||
N4, \field Ambient Temperature above Which WH has Higher Priority | ||
\type real | ||
\units C | ||
\minimum> 15.0 | ||
|
@@ -33755,7 +33757,7 @@ CoilSystem:IntegratedHeatPump:AirSource, | |
\default 1 | ||
\minimum> 0 | ||
\maximum< 10 | ||
N7 , \field Maximum Water Flow Volume before Switching from SCDWH to SCWH Mode | ||
N7, \field Maximum Water Flow Volume before Switching from SCDWH to SCWH Mode | ||
\type real | ||
\units m3 | ||
\default 0.0 | ||
|
@@ -33777,8 +33779,6 @@ CoilSystem:IntegratedHeatPump:AirSource, | |
\minimum> 0 | ||
\maximum< 10 | ||
|
||
|
||
|
||
Coil:Cooling:DX:SingleSpeed:ThermalStorage, | ||
\memo Direct expansion (DX) cooling coil and condensing unit (includes electric compressor | ||
\memo and condenser fan), single-speed with packaged integrated thermal storage for cooling. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, E+ doesn't say it's required, but code is clear: https://github.com/NREL/EnergyPlus/blob/93421b9a9d4eb1656e7fa123ded715504d107051/src/EnergyPlus/VariableSpeedCoils.cc#L2028