OutputControl:Files

[joseph-robertson]

Pull request overview

• Add new OutputControl:Files object to SDK

Please read OpenStudio Pull Requests to better understand the OpenStudio Pull Request protocol.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Model API Changes / Additions
• Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• Model API methods are tested (in src/model/test)
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
• If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• Checked behavior in OpenStudioApplication, adjusted policies as needed (src/openstudio_lib/library/OpenStudioPolicy.xml)
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes
• If methods have been deprecated, update rest of code to use the new methods

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[tijcolem]

Nice work on this @joseph-robertson. Just a note that CI is only set up to run on PRs to develop branch so it won't automatically run on this PR. I kicked off a full build for this branch instead. https://ci.commercialbuildings.dev/blue/organizations/jenkins/openstudio-develop-nightly/detail/openstudio-develop-nightly/685/pipeline

[jmarrec]

Nice & polished PR, great work @joseph-robertson

I'll modify the FT/RT tests quickly

The cache-enabled getter in Model is something we should consider, I'm not sure it's really needed or not.

[jmarrec]

I would suggest doing something similar to what I've done for OutputJSON (test all cases where a single one is true, to make absolutely sure we assigned the fields correctly). Using scripting to write the C++ it's not that annoying.

[jmarrec]

Done

[jmarrec]

I rebased onto latest v940-IOFreeze and force-pushed, make sure you refresh your index (git fetch --all)

[jmarrec]

If you're comfortable with the tiny changes I've made, go ahead and merge that to v940-IOFreeze!