Conan bump deps #4015
Merged
Conan bump deps #4015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarrec
added
Developer Issue
Pull Request - Ready for CI
jmarrec
commented
Jul 10, 2020
ConanInstall.cmake
Outdated
| websocketpp/0.8.1@bincrafters/stable | ||
| geographiclib/1.49@bincrafters/stable | ||
| swig_installer/4.0.1@bincrafters/stable | ||
| openstudio_ruby/2.5.5@nrel/testing # TODO: Temp #@nrel/stable |
There was a problem hiding this comment.
Recipe done with this PR: NREL/conan-openstudio-ruby#28
There was a problem hiding this comment.
Are just waiting for that conan recipe to pass CI and push upstream? And then once that conan package is available we can change openstudio_ruby/2.5.5@nrel/testing to openstudio_ruby/2.5.5@nrel/stable?
There was a problem hiding this comment.
Yes. I need a mac to debug why conan openstudio ruby is unhappy on the travis mac, but I failed to connect the NREL VPN yesterday after repeated attempts (not sure whether I forgot my password or my access is blocked). I need to pull my old MBP
jmarrec
commented
Jul 10, 2020
ConanInstall.cmake
Outdated
Comment on lines
30
to
33
| # Add NREL remote and place it first in line, so that if we vendor dependencies to NREL's repo they will be picked first | ||
| conan_add_remote(NAME nrel INDEX 0 | ||
| URL https://api.bintray.com/conan/commercialbuilding/nrel) | ||
|
|
There was a problem hiding this comment.
Important (especially if we go for #3940)
…cause I thought that was required, but perhaps not. Note: conan 1.27.1 is out currently
jmarrec
commented
Aug 14, 2020
jmarrec
commented
Aug 14, 2020
the 1.73 is untested, but since ruby stable is same as testing if it fails we can just revert that
jmarrec
added a commit
to openstudiocoalition/OpenStudioApplication
that referenced
this pull request
Aug 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
This PR bumps the conan dependencies to try and use only packages in conan-center-index.
A companion PR exists for openstudio ruby: NREL/conan-openstudio-ruby#28
(This is also somewhat related to #3940, since if we end up freezing the dependencies, might as well get them in order and up to date)
Pull Request Author
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)src/openstudio_lib/library/OpenStudioPolicy.xml)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.