Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for supplemental heat to ZoneHVAC:TerminalUnit:VariableRefrigerantFlow #3687

Closed
wants to merge 18 commits into from
Closed

Add support for supplemental heat to ZoneHVAC:TerminalUnit:VariableRefrigerantFlow #3687

wants to merge 18 commits into from

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Sep 24, 2019

Fix #3645 - Add support for supplemental heat to ZoneHVAC:TerminalUnit:VariableRefrigerantFlow

@jmarrec jmarrec added Enhancement Request component - HVAC Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. IDDChange labels Sep 24, 2019
@jmarrec jmarrec requested a review from kbenne September 24, 2019 10:03
@jmarrec jmarrec self-assigned this Sep 24, 2019
jmarrec added a commit to NREL/OpenStudio-resources that referenced this pull request Sep 24, 2019
@jmarrec
Add test for Supplemental heating coil VRF terminal NREL/OpenStudio#3687
52a63db
@jmarrec jmarrec mentioned this pull request Sep 24, 2019
Merged
@jmarrec
Copy link
Collaborator Author

jmarrec commented Sep 24, 2019 •
edited
Loading

I added a test in NREL/OpenStudio-resources#82 which highlighted the fact that E+ expects the supplemental HC in a different location. Found the E+ PR and the image that shows the correct location here NREL/EnergyPlus#7252

Will address that now

@jmarrec
Copy link
Collaborator Author

jmarrec commented Sep 24, 2019

Hum since I removed the defaults from the IDD (per convo with @kbenne) I also need to write VT.

@jmarrec jmarrec mentioned this pull request Sep 24, 2019
Open
@kbenne
Copy link
Contributor

kbenne commented Sep 25, 2019

@jmarrec sorry I merged your pump enhancements and now there are conflicts on this one. I will resolve.

@jmarrec
Copy link
Collaborator Author

jmarrec commented Sep 26, 2019

@kbenne I merged develop in an resolved the "merge conflicts" (which consisted in placing the VT stuff from each one after the other)

@jmarrec jmarrec mentioned this pull request Sep 26, 2019
Closed
@jmarrec jmarrec mentioned this pull request Oct 14, 2019
Closed
kbenne added a commit to openstudiocoalition/OpenStudioApplication that referenced this pull request Oct 28, 2019
@kbenne
App related components of OS Core PRs
4bdb894 
NREL/OpenStudio#3697
NREL/OpenStudio#3694
NREL/OpenStudio#3687
@jmarrec
Copy link
Collaborator Author

jmarrec commented Nov 22, 2019 •
edited
Loading

@kbenne this one is also already in develop3 via #3752 (cf for eg the first commit): ab48b0e

So probably can close unless you think it's necessary to add to 2.9.1.

@kbenne kbenne closed this Nov 22, 2019
@kbenne
Copy link
Contributor

kbenne commented Nov 22, 2019

I see ab48b0e in develop3, but not develop. I'm good with that so I closed.

@jmarrec jmarrec deleted the 3645_VRFTerminal_Supplemental branch November 22, 2019 19:58
@jmarrec jmarrec mentioned this pull request Aug 5, 2020
Closed
jmarrec added a commit that referenced this pull request Aug 5, 2020
@jmarrec
Fix #4016 - Move VT from 2.9.0 to 3.0.0 for new fields at end of the …
6a11896 
…ZoneHVAC:TerminalUnit:VariableRefrigerantFlow

Note #3687 was originally planned for 2.9.0 inclusion, so VT was there. But it was only merged to develop3 and hence relased in 3.0.0
Moving it in the right location, as needed per #4016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbenne kbenne kbenne left review comments

Assignees

@kbenne kbenne

@jmarrec jmarrec

Labels
component - HVAC Enhancement Request IDDChange Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E+ Change: Add support for supplemental heat to ZoneHVAC:TerminalUnit:VariableRefrigerantFlow
2 participants
@jmarrec @kbenne