Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ CLI: run.log is huge and missing the runner.registerWarning messages #5030

Closed
2 tasks done
Tracked by #5016
jmarrec opened this issue Nov 13, 2023 · 0 comments · Fixed by #5035
Closed
2 tasks done
Tracked by #5016

C++ CLI: run.log is huge and missing the runner.registerWarning messages #5030

jmarrec opened this issue Nov 13, 2023 · 0 comments · Fixed by #5035
Labels
component - CLI labs severity - Normal Bug Triage Issue needs to be assessed and labeled, further information on reported might be needed

Comments

@jmarrec
Copy link
Collaborator

jmarrec commented Nov 13, 2023 •
edited
Loading

Issue overview

Current Behavior

  • The run.log is huge -- used to have three messages in it, now it has hundreds of messages.
  • If a reporting measure issues a warning (runner.registerWarning("WARNING TEST")), the warning does not end up in the run.log file.

Expected Behavior

Should match the classic (Ruby) CLI.

Possible Solution

I think the piggy backing of runner.registerWarning and similar is happening here:

https://github.com/NREL/OpenStudio-workflow-gem/blob/696306b5b24cd597edc6ab04faa1e618f99db190/lib/openstudio/workflow_runner.rb#L189-L217

Details

Environment

Some additional details about your environment for this issue (if relevant):

  • Platform (Operating system, version): all
  • Version of OpenStudio (if using an intermediate build, include SHA): 3.7.0-rc2

Context
@jmarrec jmarrec added severity - Normal Bug component - CLI Triage Issue needs to be assessed and labeled, further information on reported might be needed labs labels Nov 13, 2023
@jmarrec jmarrec mentioned this issue Nov 13, 2023
Closed
5 tasks
jmarrec added a commit that referenced this issue Nov 14, 2023
@jmarrec
#5030 - add testing for run.log (advanced pytest inside)
e65a405
jmarrec added a commit that referenced this issue Nov 14, 2023
@jmarrec
#5030 - Make runner.registerWarning and co also LOG a message like wo…
940ea02 
…rkflow_runner.rb used to do
This was referenced Nov 14, 2023
Merged
Open
jmarrec added a commit that referenced this issue Nov 15, 2023
@jmarrec
#5030 - add testing for run.log (advanced pytest inside)
ab00964
jmarrec added a commit that referenced this issue Nov 15, 2023
@jmarrec
#5030 - Make runner.registerWarning and co also LOG a message like wo…
a877336 
…rkflow_runner.rb used to do
jmarrec added a commit that referenced this issue Nov 15, 2023
@jmarrec
Merge pull request #5035 from NREL/5030-logger_issues
dc35f3e 
Fix #5030 - C++ CLI: run.log is huge and missing the runner.registerWarning messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component - CLI labs severity - Normal Bug Triage Issue needs to be assessed and labeled, further information on reported might be needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #5030 - C++ CLI: run.log is huge and missing the runner.registerWarning messages NREL/OpenStudio
1 participant
@jmarrec