Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum zone ventilation efficiency #3898

Closed
lymereJ opened this issue Feb 28, 2020 · 6 comments
Closed

Minimum zone ventilation efficiency #3898

lymereJ opened this issue Feb 28, 2020 · 6 comments

Comments

@lymereJ
Copy link

lymereJ commented Feb 28, 2020

Enhancement Request

The SDK allows users to set/get the zone air distribution effectiveness in heating/cooling mode via DesignSpecificationZoneAirDistribution and SizingZone but not the minimum zone ventilation efficiency, which is a valid input in EnergyPlus. It would great if the later could be added.

@lymereJ lymereJ added Enhancement Request Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Feb 28, 2020
@lymereJ lymereJ changed the title Set minimum zone ventilation efficiency Minimum zone ventilation efficiency Feb 28, 2020
@jmarrec
Copy link
Collaborator

jmarrec commented Mar 2, 2020

Confirmed it's missing in OpenStudio, and easy to add.

OS:DesignSpecification:ZoneAirDistribution,
   [...]
   N3;  \field Zone Secondary Recirculation Fraction
        \type real
        \default 0.0
        \minimum 0.0
        \units dimensionless

replace with

OS:DesignSpecification:ZoneAirDistribution,
   [...]
   N3,  \field Zone Secondary Recirculation Fraction
        \type real
        \default 0.0
        \minimum 0.0
        \units dimensionless
   N4;  \field Minimum Zone Ventilation Efficiency
        \type real
        \default 0.0
        \minimum 0.0
        \maximum 1.0
        \units dimensionless

@jmarrec jmarrec added component - Model and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Mar 2, 2020
@jmarrec
Copy link
Collaborator

jmarrec commented Mar 2, 2020

Hmmm, actually, I seems that while the object appears to be wrapped in the model API (DesignSpecificationZoneAirDistribution has a class, and registered constructors etc), it's not being used during forward translation at all. Instead the OS:Sizing:Zone is the one that adds some of the fields directly.

REGISTER_CONSTRUCTOR(DesignSpecificationZoneAirDistribution);

class MODEL_API DesignSpecificationZoneAirDistribution : public ModelObject {

It's not SWIG'ed either.

@lymereJ
Copy link
Author

lymereJ commented Mar 3, 2020

Could this be included in the next OpenStudio release?

@tijcolem tijcolem added this to the OpenStudio SDK 3.0.0 milestone Mar 6, 2020
@tijcolem
Copy link
Collaborator

tijcolem commented Mar 6, 2020

@jmarrec Can we get this in for 3.0.0? Run regression tests to make sure no major changes?

@jmarrec
Copy link
Collaborator

jmarrec commented Mar 6, 2020

Its possible, but not as straightforward as I had thought initially since the existing class is actually not used. Requires modifying the model API to make use of it, or strapping the new field onto the SizingZone object like it is now (less work for sure).

@kbenne thoughts? I would assume put it on OS:Sizing:Zone?

jmarrec added a commit that referenced this issue Mar 10, 2020
 (has nothing to do here, but trying to save time rebuilding and need to switch machines tomorrow)
jmarrec added a commit that referenced this issue Mar 11, 2020
…:ZoneAirDistribution at end of Sizing:Zone and prefix them with "Design"

Not adding 'Zone Air Distribution Effectiveness Schedule Name'
jmarrec added a commit that referenced this issue Mar 11, 2020
@tijcolem
Copy link
Collaborator

closed and merged in #3915

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants