Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FloorspaceJS json north axis not being imported into OS model #3585

Closed
antonszilasi opened this issue Jun 28, 2019 · 0 comments
Closed

FloorspaceJS json north axis not being imported into OS model #3585

antonszilasi opened this issue Jun 28, 2019 · 0 comments
Assignees

Comments

@antonszilasi
Copy link

antonszilasi commented Jun 28, 2019

@macumber

I have created a floor space model where I rotated the north axis by -270 degrees/90 degrees (see the jpg below)

270 degrees rotated

This north axis rotation can be seen in the north_axis property of the Floorspace JS json which is produced from the floor space app.

north_axis

However it appears that this north axis rotation is not be carried forward to the OS model when the Floorspace JS json is converted to a OS model using the following code:

      floorplan = OpenStudio::FloorplanJS::load(json_data)
      if floorplan.empty?
        raise ArgumentError.new("Cannot load floorplan from '#{floorplan_path}'.")
      end

      scene = floorplan.get.toThreeScene(true)

      rt = OpenStudio::Model::ThreeJSReverseTranslator.ne
[floorplan90degreesRotated.zip](https://github.com/NREL/OpenStudio/files/3340088/floorplan90degreesRotated.zip)
w

      model = rt.modelFromThreeJS(scene)

As the north axis of the OS model is set to 0.

Could you please confirm that this is the case, and if it is could you please fix this issue in the Openstudio api ASAP.

I have attached both the FloorSpace JS json and the OS model created from it in the zip file.

Thank you!
(https://github.com/NREL/OpenStudio/files/3340096/floorplan270degreesRotated.zip)

@macumber macumber added this to the OpenStudio 2.9.0 milestone Jun 28, 2019
@macumber macumber self-assigned this Jun 28, 2019
macumber added a commit that referenced this issue Jul 11, 2019
macumber pushed a commit that referenced this issue Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants