Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web pages update #768

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Conversation

IainMacdonald
Copy link
Contributor

Updates to the web interface:

  • The pagination was not working properly as the Kaminari gem defaults to 25 entries per page and the display was set to 50. Added the gem config file and set to 200 entries per page.
  • For the pie chart sorted the datapoints and added differentiation between successful simulations and failures; linked the cases to specific colors (picked from the css). This ensures that the pie chart display is consistent.
  • Added logic to estimate the time remaining for the analysis. It does not display the estimate until at least 10% of the datapoints are complete.
  • Added 'const' declaration to the JavaScript variables in dashboard (suggested by our code checker).
  • Some minor updates to code layout in the files (tabs/spaces/carriage returns) to improve readability.

@brianlball
Copy link
Contributor

@IainMacdonald this looks cool at first glance. Will have to build it and check it out.
we are currently trying to get the tests back up after the change to Ruby3.
i'm curious about the analysis estimation time to complete. when I added the ability to do 2 analyses at a time, the way we were calculating actual analysis runtime was no longer valid. I have not had a chance to really think about how to fix that, but maybe this could help?

@IainMacdonald
Copy link
Contributor Author

Please do build and check - its a bit unnerving that all the auto checks have failed! The time to complete may need some appreciation of the number of workers but its in the right ball park just now. When it gets to the last batch of data points the end comes more quickly as they all complete at about the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants