-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Openstudio 3.2.0-rc1 #624
Conversation
… gems installed via bundler
… mimemagic with may be tricky on windows
@brianlball This currently excludes the UrbanOpt gems but I think this is good to go otherwise. Once those UrbanOpt gems are available we can bump to a new RC or include them in 3.2.1 |
Dockerfile
Outdated
@@ -4,7 +4,7 @@ | |||
# NOTES: Currently this is one big dockerfile and non-optimal. | |||
|
|||
#may include suffix | |||
ARG OPENSTUDIO_VERSION=3.1.0 | |||
ARG OPENSTUDIO_VERSION=develop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be 3.2.0 instead of develop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we should pin this to 3.2.0-rc1. thanks for catching!
@@ -105,7 +105,7 @@ | |||
] | |||
|
|||
# run an analysis | |||
command = "#{@bundle_cmd} #{@meta_cli} run_analysis --debug --verbose '#{@project}/URBANopt_singlerun.json' 'http://#{@host}' -z 'URBANopt_NSGA' -a single_run" | |||
command = "#{@bundle_cmd} #{@meta_cli} run_analysis --debug --verbose '#{@project}/UrbanOpt_singlerun.json' 'http://#{@host}' -z 'UrbanOpt_NSGA' -a single_run" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are getting changed to URBANopt to match the trademarks or whatever. thats in another PR, but not really an issue here I suppose since these tests are not running right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are not running right now but we'll enable them as soon as the UrbanOpt gems are released. I guess we resolve any conflicts if there are any when that time comes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one question about develop vs 3.2.0
otherwise, nice work! dealing with all those gem updates was challenging i'm sure!
This PR updates to OpenStudio SDK 3.2.0-rc1 and bumps up many of the server gem dependencies to the latest (including rails).