Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix afn_single_zone_xx tests #43

Open
1 of 2 tasks
jmarrec opened this issue Mar 26, 2018 · 4 comments
Open
1 of 2 tasks

Fix afn_single_zone_xx tests #43

jmarrec opened this issue Mar 26, 2018 · 4 comments

Comments

@jmarrec
Copy link
Contributor

jmarrec commented Mar 26, 2018

Checklist:

  • Fix failing afn_single_zone_ac.rb

  • afn_single_zone_nv.osm is failing in 2.5.0


afn_single_zone_ac.rb is failing.

Test was added in #39

With current OpenStudio develop, run.log shows:

[16:01:23.770659 ERROR] Found error in state 'translator' with message ["std::bad_cast::/ruby/2.2.0/gems/openstudio-workflow-1.3.2/lib/openstudio/workflow/util/model.rb:66:in `translateModel'\n:/ruby/2.2.0/gems/openstudio-workflow-1.3.2/lib/openstudio/workflow/util/model.rb:66:in `translate_to_energyplus'\n:/ruby/2.2.0/gems/openstudio-workflow-1.3.2/lib/openstudio/workflow/jobs/run_translation.rb:54:in `perform'\n:/ruby/2.2.0/gems/openstudio-workflow-1.3.2/lib/openstudio/workflow/run.rb:261:in `step'\n:/ruby/2.2.0/gems/openstudio-workflow-1.3.2/lib/openstudio/workflow/run.rb:210:in `run'\n:/openstudio_cli.rb:821:in `execute'\n:/openstudio_cli.rb:620:in `execute'\n:/openstudio_cli.rb:1547:in `<main>'\neval:85:in `eval'\neval:85:in `require_embedded_absolute'\neval:70:in `block in require'\neval:64:in `each'\neval:64:in `require'\neval:2:in `<main>'"]}

afn_single_zone_nv.osm is failing too.

@jmarrec jmarrec changed the title Fix Fix afn_single_zone_xx tests Mar 26, 2018
@macumber
Copy link
Contributor

The AC version of this test is not yet working so we have commented out

@jmarrec
Copy link
Contributor Author

jmarrec commented Apr 3, 2018

afn_single_zone_nv.osm is failing in 2.5.0 official (was working in 2.4.3), run.log shows:

[08:04:33.543566 ERROR] Found error in state 'translator' with message ["/home/bldadmin/openstudio/openstudiocore/src/model/AirflowNetworkZone.cpp@110 : Object of type 'OS:AirflowNetworkZone' and named '{ff634789-3b5c-4747-98c9-153c63b0c8b5}' does not have an Thermal Zone attached.::/ruby/2.2.0/gems/openstudio-workflow-1.3.2/lib/openstudio/workflow/util/model.rb:66:in `translateModel'\n:/ruby/2.2.0/gems/openstudio-workflow-1.3.2/lib/openstudio/workflow/util/model.rb:66:in `translate_to_energyplus'\n:/ruby/2.2.0/gems/openstudio-workflow-1.3.2/lib/openstudio/workflow/jobs/run_translation.rb:54:in `perform'\n:/ruby/2.2.0/gems/openstudio-workflow-1.3.2/lib/openstudio/workflow/run.rb:261:in `step'\n:/ruby/2.2.0/gems/openstudio-workflow-1.3.2/lib/openstudio/workflow/run.rb:210:in `run'\n:/openstudio_cli.rb:821:in `execute'\n:/openstudio_cli.rb:620:in `execute'\n:/openstudio_cli.rb:1547:in `<main>'\neval:85:in `eval'\neval:85:in `require_embedded_absolute'\neval:70:in `block in require'\neval:64:in `each'\neval:64:in `require'\neval:2:in `<main>'"]}

@jmarrec
Copy link
Contributor Author

jmarrec commented Apr 3, 2018

Re: afn_single_zone_nv.osm

This a missing version translation thing.
In 2.4.3, there was no "Name" field, which was introduced in 2.5.0, but not handled in Version translation.

2_4_3/OpenStudio.idd

OS:AirflowNetworkZone,
      \min-fields 9
      \memo This object is used to simultaneously control a thermal zone's window and door openings,
      \memo both exterior and interior.
  A1, \field Handle
      \type handle
      \required-field
  A2, \field Thermal Zone Name
      \required-field
      \type object-list
      \object-list ThermalZoneNames
      \note Enter the zone name where ventilation control is required.
[...]

2_5_0/OpenStudio.idd

OS:AirflowNetworkZone,
      \min-fields 9
      \memo This object is used to simultaneously control a thermal zone's window and door openings,
      \memo both exterior and interior.
  A1, \field Handle
      \type handle
      \required-field
  A2, \field Name
      \required-field
      \type alpha
      \reference AirflowNetworkNodeAndZoneNames
  A3, \field Thermal Zone Name
      \required-field
      \type object-list
      \object-list ThermalZoneNames
      \note Enter the zone name where ventilation control is required.
[...]

jmarrec added a commit to jmarrec/OpenStudio that referenced this issue Apr 3, 2018
Handle 2.4.3 to 2.5.0 version translation for AirflowNetworkZone (inserted 'Name' field)
@jmarrec
Copy link
Contributor Author

jmarrec commented Apr 3, 2018

The test_afn_single_zone_nv_osm is now working after changes done in NREL/OpenStudio#3085

The AC test (and underlying model API changes) are still on a TODO. Added a checklist in first post above.

macumber added a commit to NREL/OpenStudio that referenced this issue Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants