Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GSHP debug statement in test_hvac_sizing #1912

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Remove GSHP debug statement in test_hvac_sizing #1912

merged 2 commits into from
Jan 17, 2025

Conversation

yzhou601
Copy link
Collaborator

Pull Request Description

[description here]

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@yzhou601 yzhou601 self-assigned this Jan 17, 2025
@yzhou601 yzhou601 marked this pull request as ready for review January 17, 2025 00:22
@yzhou601 yzhou601 requested a review from shorowit January 17, 2025 00:22
@shorowit shorowit merged commit 459eeb3 into master Jan 17, 2025
@shorowit shorowit deleted the hvac_sizing_bugfix branch January 17, 2025 01:14
@joseph-robertson joseph-robertson mentioned this pull request Jan 17, 2025
Merged
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shorowit shorowit shorowit approved these changes

Assignees

@yzhou601 yzhou601

Labels
None yet
Projects
OpenStudio-HPXML
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yzhou601 @shorowit