-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow simulating whole SFA/MF buildings #1456
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dio-HPXML into whole_sfa_mf_models
…ned zones, but matters for duct zones).
…HPXML into whole_sfa_mf_models_unit_multiplier # Conflicts: # HPXMLtoOpenStudio/measure.rb # HPXMLtoOpenStudio/measure.xml # HPXMLtoOpenStudio/resources/battery.rb # HPXMLtoOpenStudio/resources/geometry.rb # HPXMLtoOpenStudio/resources/hotwater_appliances.rb # HPXMLtoOpenStudio/resources/hvac.rb # HPXMLtoOpenStudio/resources/waterheater.rb # ReportSimulationOutput/measure.rb # ReportSimulationOutput/measure.xml
…g elements. Not everything works yet, but many things do.
…com/NREL/OpenStudio-HPXML into whole_sfa_mf_models_unit_multiplier
…et's see what breaks...
…com/NREL/OpenStudio-HPXML into whole_sfa_mf_models_unit_multiplier
…MF building. Still need to fix and double-check some things.
…o whole_sfa_mf_models_unit_multiplier # Conflicts: # HPXMLtoOpenStudio/measure.xml # HPXMLtoOpenStudio/resources/hotwater_appliances.rb # HPXMLtoOpenStudio/resources/hpxml_defaults.rb # HPXMLtoOpenStudio/tests/test_defaults.rb # tasks.rb # workflow/tests/base_results/results.csv # workflow/tests/base_results/results_bills.csv
…o whole_sfa_mf_models_unit_multiplier # Conflicts: # HPXMLtoOpenStudio/measure.xml
…com/NREL/OpenStudio-HPXML into whole_sfa_mf_models_unit_multiplier
… up workflow tests (exclude real homes).
…dings.xml to base-multiple-sfd-buildings.xml for clarity. Fix CI tests.
…com/NREL/OpenStudio-HPXML into whole_sfa_mf_models_unit_multiplier
…com/NREL/OpenStudio-HPXML into whole_sfa_mf_models_unit_multiplier
8 tasks
shorowit
added a commit
that referenced
this pull request
Nov 3, 2023
… Adds error-checking to prevent this going forward. Some other minor misc cleanup.
This was referenced Nov 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #1376. Closes #1450 and closes #1492.
If an HPXML file is submitted where there are multiple
Building
elements, each representing an individual dwelling unit, you can now tell OS-HPXML that you want to run ALL units, which creates a single combined OS/E+ model. The ability to just run one of theBuilding
IDs is also still available.Also allows dwelling unit multipliers via
BuildingConstruction/NumberofUnits
(as described here) for runtime performance reasons. When provided, simulation outputs will reflect this multiplier. When modeling individual dwelling units, there isn't that much of a benefit since all the OS-HPXML outputs could simply be multiplied by this value by the end user/software during a post-processing. But when modeling whole SFA/MF buildings, different units in the building may have different multipliers, so it cannot be performed during a post-processing step.Breaking change: Multiple elements move from
SoftwareInfo/extension
toBuildingDetails/BuildingSummary/extension
to allow variation across MF dwelling units:-
HVACSizingControl
-
ShadingControl
-
SchedulesFilePath
-
NaturalVentilationAvailabilityDaysperWeek
Finally, the HPXML class has been updated to support multiple buildings. Previously:
Now it will look like:
TODO:
in.xml
echoes the entire HPXML.Checklist
PR Author: Check these when they're done. Not all may apply.
strikethroughand check any that do not apply.PR Reviewer: Verify each has been completed.
Schematron validator (EPvalidator.xml
) has been updatedtasks.rb
)HPXMLtoOpenStudio/tests
and/orworkflow/tests/hpxml_translator_test.rb
)openstudio tasks.rb update_measures
has been run