Manufactured home belly ducts

.gitignore

@@ -1,3 +1,4 @@
+.ruby-version
 /coverage
 /docs/_build
 /results

BuildResidentialHPXML/measure.rb

@@ -181,6 +181,7 @@ def arguments(model) # rubocop:disable Lint/UnusedMethodArgument
     unit_type_choices << HPXML::ResidentialTypeSFD
     unit_type_choices << HPXML::ResidentialTypeSFA
     unit_type_choices << HPXML::ResidentialTypeApartment
+    unit_type_choices << HPXML::ResidentialTypeManufactured
 
     arg = OpenStudio::Measure::OSArgument::makeChoiceArgument('geometry_unit_type', unit_type_choices, true)
     arg.setDisplayName('Geometry: Unit Type')
@@ -317,6 +318,8 @@ def arguments(model) # rubocop:disable Lint/UnusedMethodArgument
     foundation_type_choices << HPXML::FoundationTypeBasementConditioned
     foundation_type_choices << HPXML::FoundationTypeAmbient
     foundation_type_choices << HPXML::FoundationTypeAboveApartment # I.e., adiabatic
+    foundation_type_choices << "#{HPXML::FoundationTypeBellyAndWing}WithSkirt"
+    foundation_type_choices << "#{HPXML::FoundationTypeBellyAndWing}NoSkirt"
 
     arg = OpenStudio::Measure::OSArgument::makeChoiceArgument('geometry_foundation_type', foundation_type_choices, true)
     arg.setDisplayName('Geometry: Foundation Type')
@@ -1450,6 +1453,7 @@ def arguments(model) # rubocop:disable Lint/UnusedMethodArgument
     duct_location_choices << HPXML::LocationOtherHeatedSpace
     duct_location_choices << HPXML::LocationOtherMultifamilyBufferSpace
     duct_location_choices << HPXML::LocationOtherNonFreezingSpace
+    duct_location_choices << HPXML::LocationManufacturedHomeBelly
 
     arg = OpenStudio::Measure::OSArgument::makeChoiceArgument('ducts_leakage_units', duct_leakage_units_choices, true)
     arg.setDisplayName('Ducts: Leakage Units')
@@ -1793,6 +1797,7 @@ def arguments(model) # rubocop:disable Lint/UnusedMethodArgument
     water_heater_location_choices << HPXML::LocationCrawlspaceVented
     water_heater_location_choices << HPXML::LocationCrawlspaceUnvented
     water_heater_location_choices << HPXML::LocationCrawlspaceConditioned
+    water_heater_location_choices << HPXML::LocationManufacturedHomeBelly
     water_heater_location_choices << HPXML::LocationOtherExterior
     water_heater_location_choices << HPXML::LocationOtherHousingUnit
     water_heater_location_choices << HPXML::LocationOtherHeatedSpace
@@ -3499,7 +3504,7 @@ def self.create_geometry_envelope(runner, model, args)
       args[:geometry_foundation_height] = 0.0
       args[:geometry_foundation_height_above_grade] = 0.0
       args[:geometry_rim_joist_height] = 0.0
-    elsif args[:geometry_foundation_type] == HPXML::FoundationTypeAmbient
+    elsif (args[:geometry_foundation_type] == HPXML::FoundationTypeAmbient) || args[:geometry_foundation_type].start_with?(HPXML::FoundationTypeBellyAndWing)
       args[:geometry_rim_joist_height] = 0.0
     end
 
@@ -3514,6 +3519,8 @@ def self.create_geometry_envelope(runner, model, args)
       success = Geometry.create_single_family_attached(model: model, **args)
     elsif args[:geometry_unit_type] == HPXML::ResidentialTypeApartment
       success = Geometry.create_apartment(model: model, **args)
+    elsif args[:geometry_unit_type] == HPXML::ResidentialTypeManufactured
+      success = Geometry.create_single_family_detached(runner: runner, model: model, **args)
     end
     return false if not success
 
@@ -3895,7 +3902,7 @@ def self.set_site(hpxml, args)
           hpxml.site.vertical_surroundings = HPXML::VerticalSurroundingsNoAboveOrBelow
         end
       end
-    elsif [HPXML::ResidentialTypeSFD].include? args[:geometry_unit_type]
+    elsif [HPXML::ResidentialTypeSFD, HPXML::ResidentialTypeManufactured].include? args[:geometry_unit_type]
       hpxml.site.surroundings = HPXML::SurroundingsStandAlone
       hpxml.site.vertical_surroundings = HPXML::VerticalSurroundingsNoAboveOrBelow
     end
@@ -4598,19 +4605,33 @@ def self.set_foundations(hpxml, args)
         next unless (foundation_locations.include? surface.interior_adjacent_to) ||
                     (foundation_locations.include? surface.exterior_adjacent_to) ||
                     (surf_type == 'slabs' && surface.interior_adjacent_to == HPXML::LocationLivingSpace) ||
-                    (surf_type == 'floors' && surface.exterior_adjacent_to == HPXML::LocationOutside)
+                    (surf_type == 'floors' && [HPXML::LocationOutside, HPXML::LocationManufacturedHomeUnderBelly].include?(surface.exterior_adjacent_to))
 
         surf_hash['ids'] << surface.id
       end
     end
 
+    if args[:geometry_foundation_type].start_with?(HPXML::FoundationTypeBellyAndWing)
+      foundation_type = HPXML::FoundationTypeBellyAndWing
+      if args[:geometry_foundation_type].end_with?('WithSkirt')
+        belly_wing_skirt_present = true
+      elsif args[:geometry_foundation_type].end_with?('NoSkirt')
+        belly_wing_skirt_present = false
+      else
+        fail 'Unepected belly and wing foundation type.'
+      end
+    else
+      foundation_type = args[:geometry_foundation_type]
+    end
+
     hpxml.foundations.add(id: "Foundation#{hpxml.foundations.size + 1}",
-                          foundation_type: args[:geometry_foundation_type],
+                          foundation_type: foundation_type,
                           attached_to_slab_idrefs: surf_ids['slabs']['ids'],
                           attached_to_floor_idrefs: surf_ids['floors']['ids'],
                           attached_to_foundation_wall_idrefs: surf_ids['foundation_walls']['ids'],
                           attached_to_wall_idrefs: surf_ids['walls']['ids'],
-                          attached_to_rim_joist_idrefs: surf_ids['rim_joists']['ids'])
+                          attached_to_rim_joist_idrefs: surf_ids['rim_joists']['ids'],
+                          belly_wing_skirt_present: belly_wing_skirt_present)
   end
 
   def self.set_heating_systems(hpxml, args)

BuildResidentialHPXML/measure.xml

@@ -3,8 +3,8 @@
   <schema_version>3.1</schema_version>
   <name>build_residential_hpxml</name>
   <uid>a13a8983-2b01-4930-8af2-42030b6e4233</uid>
-  <version_id>d20becd1-748d-4de9-a6d6-2d3fe1777b62</version_id>
-  <version_modified>2023-06-23T14:29:10Z</version_modified>
+  <version_id>438aad8c-a697-41b3-8115-e776cf7d2bc8</version_id>
+  <version_modified>2023-06-23T16:49:59Z</version_modified>
   <xml_checksum>2C38F48B</xml_checksum>
   <class_name>BuildResidentialHPXML</class_name>
   <display_name>HPXML Builder</display_name>
@@ -553,6 +553,10 @@
           <value>apartment unit</value>
           <display_name>apartment unit</display_name>
         </choice>
+        <choice>
+          <value>manufactured home</value>
+          <display_name>manufactured home</display_name>
+        </choice>
       </choices>
     </argument>
     <argument>
@@ -808,6 +812,14 @@
           <value>AboveApartment</value>
           <display_name>AboveApartment</display_name>
         </choice>
+        <choice>
+          <value>BellyAndWingWithSkirt</value>
+          <display_name>BellyAndWingWithSkirt</display_name>
+        </choice>
+        <choice>
+          <value>BellyAndWingNoSkirt</value>
+          <display_name>BellyAndWingNoSkirt</display_name>
+        </choice>
       </choices>
     </argument>
     <argument>
@@ -3052,6 +3064,10 @@
           <value>other non-freezing space</value>
           <display_name>other non-freezing space</display_name>
         </choice>
+        <choice>
+          <value>manufactured home belly</value>
+          <display_name>manufactured home belly</display_name>
+        </choice>
       </choices>
     </argument>
     <argument>
@@ -3175,6 +3191,10 @@
           <value>other non-freezing space</value>
           <display_name>other non-freezing space</display_name>
         </choice>
+        <choice>
+          <value>manufactured home belly</value>
+          <display_name>manufactured home belly</display_name>
+        </choice>
       </choices>
     </argument>
     <argument>
@@ -3788,6 +3808,10 @@
           <value>crawlspace - conditioned</value>
           <display_name>crawlspace - conditioned</display_name>
         </choice>
+        <choice>
+          <value>manufactured home belly</value>
+          <display_name>manufactured home belly</display_name>
+        </choice>
         <choice>
           <value>other exterior</value>
           <display_name>other exterior</display_name>
@@ -6679,13 +6703,13 @@
       <filename>measure.rb</filename>
       <filetype>rb</filetype>
       <usage_type>script</usage_type>
-      <checksum>DD2D104D</checksum>
+      <checksum>E80048BE</checksum>
     </file>
     <file>
       <filename>geometry.rb</filename>
       <filetype>rb</filetype>
       <usage_type>resource</usage_type>
-      <checksum>2448A56F</checksum>
+      <checksum>6D43B4D8</checksum>
     </file>
     <file>
       <filename>build_residential_hpxml_test.rb</filename>

BuildResidentialHPXML/resources/geometry.rb

@@ -547,7 +547,7 @@ def self.create_single_family_detached(runner:,
         HPXML::FoundationTypeCrawlspaceConditioned,
         HPXML::FoundationTypeBasementUnconditioned,
         HPXML::FoundationTypeBasementConditioned,
-        HPXML::FoundationTypeAmbient].include? foundation_type
+        HPXML::FoundationTypeAmbient].include?(foundation_type) || foundation_type.start_with?(HPXML::FoundationTypeBellyAndWing)
 
       z = -foundation_height
 
@@ -577,6 +577,8 @@ def self.create_single_family_detached(runner:,
         foundation_space_name = HPXML::LocationBasementConditioned
       elsif foundation_type == HPXML::FoundationTypeAmbient
         foundation_space_name = HPXML::LocationOutside
+      elsif foundation_type.start_with?(HPXML::FoundationTypeBellyAndWing)
+        foundation_space_name = HPXML::LocationManufacturedHomeUnderBelly
       end
       foundation_zone.setName(foundation_space_name)
       foundation_space.setName(foundation_space_name)
@@ -2226,7 +2228,7 @@ def self.create_apartment(model:,
 
   # Shift all spaces up by foundation height for ambient foundation
   def self.apply_ambient_foundation_shift(model, foundation_type, foundation_height)
-    if foundation_type == HPXML::FoundationTypeAmbient
+    if [HPXML::FoundationTypeAmbient, HPXML::FoundationTypeBellyAndWing].include?(foundation_type)
       m = initialize_transformation_matrix(OpenStudio::Matrix.new(4, 4, 0))
       m[2, 3] = -foundation_height
       model.getSpaces.each do |space|

Changelog.md

@@ -1,5 +1,7 @@
 ## OpenStudio-HPXML v1.7.0
+
 __New Features__
+- Adds manufactured home belly as a foundation type and allows modeling ducts in a manufactured home belly.
 
 __Bugfixes__
 - Fixes lighting multipliers not being applied when kWh/yr inputs are used.

HPXMLtoOpenStudio/measure.rb

@@ -632,6 +632,12 @@ def self.add_floors(runner, model, spaces)
         surface.setWindExposure('NoWind')
       elsif floor.is_floor
         surface.setSunExposure('NoSun')
+        if floor.exterior_adjacent_to == HPXML::LocationManufacturedHomeUnderBelly
+          foundation = @hpxml.foundations.find { |x| x.to_location == floor.exterior_adjacent_to }
+          if foundation.belly_wing_skirt_present
+            surface.setWindExposure('NoWind')
+          end
+        end
       end
 
       # Apply construction
@@ -2404,7 +2410,7 @@ def self.set_surface_interior(model, spaces, surface, hpxml_surface)
   def self.set_surface_exterior(model, spaces, surface, hpxml_surface)
     exterior_adjacent_to = hpxml_surface.exterior_adjacent_to
     is_adiabatic = hpxml_surface.is_adiabatic
-    if exterior_adjacent_to == HPXML::LocationOutside
+    if [HPXML::LocationOutside, HPXML::LocationManufacturedHomeUnderBelly].include? exterior_adjacent_to
       surface.setOutsideBoundaryCondition('Outdoors')
     elsif exterior_adjacent_to == HPXML::LocationGround
       surface.setOutsideBoundaryCondition('Foundation')
@@ -2581,11 +2587,17 @@ def self.set_subsurface_exterior(surface, spaces, model, hpxml_surface)
 
   def self.set_foundation_and_walls_top()
     @foundation_top = 0
+    @hpxml.floors.each do |floor|
+      # Keeping the floor at ground level for ASHRAE 140 tests yields the expected results
+      if floor.is_floor && floor.is_exterior && !@apply_ashrae140_assumptions
+        @foundation_top = 2.0
+      end
+    end
     @hpxml.foundation_walls.each do |foundation_wall|
       top = -1 * foundation_wall.depth_below_grade + foundation_wall.height
       @foundation_top = top if top > @foundation_top
     end
-    @walls_top = @foundation_top + 8.0 * @ncfl_ag
+    @walls_top = @foundation_top + @hpxml.building_construction.average_ceiling_height * @ncfl_ag
   end
 
   def self.set_heating_and_cooling_seasons()

HPXMLtoOpenStudio/measure.xml

@@ -3,8 +3,8 @@
   <schema_version>3.1</schema_version>
   <name>hpxm_lto_openstudio</name>
   <uid>b1543b30-9465-45ff-ba04-1d1f85e763bc</uid>
-  <version_id>497c1143-8a0c-4426-94f7-293d964b24d1</version_id>
-  <version_modified>2023-06-23T14:39:55Z</version_modified>
+  <version_id>95206b77-144f-4d10-82a8-9d4fe1e4cd22</version_id>
+  <version_modified>2023-06-23T16:50:01Z</version_modified>
   <xml_checksum>D8922A73</xml_checksum>
   <class_name>HPXMLtoOpenStudio</class_name>
   <display_name>HPXML to OpenStudio Translator</display_name>
@@ -130,7 +130,7 @@
       <filename>measure.rb</filename>
       <filetype>rb</filetype>
       <usage_type>script</usage_type>
-      <checksum>718E02EC</checksum>
+      <checksum>7B81BF09</checksum>
     </file>
     <file>
       <filename>airflow.rb</filename>
@@ -226,7 +226,7 @@
       <filename>geometry.rb</filename>
       <filetype>rb</filetype>
       <usage_type>resource</usage_type>
-      <checksum>A2D4F7BA</checksum>
+      <checksum>66B20F30</checksum>
     </file>
     <file>
       <filename>hotwater_appliances.rb</filename>
@@ -238,19 +238,19 @@
       <filename>hpxml.rb</filename>
       <filetype>rb</filetype>
       <usage_type>resource</usage_type>
-      <checksum>07893D69</checksum>
+      <checksum>44BBB9C7</checksum>
     </file>
     <file>
       <filename>hpxml_defaults.rb</filename>
       <filetype>rb</filetype>
       <usage_type>resource</usage_type>
-      <checksum>E33010DD</checksum>
+      <checksum>C7A530D7</checksum>
     </file>
     <file>
       <filename>hpxml_schema/HPXML.xsd</filename>
       <filetype>xsd</filetype>
       <usage_type>resource</usage_type>
-      <checksum>E0A455E1</checksum>
+      <checksum>5300D228</checksum>
     </file>
     <file>
       <filename>hpxml_schema/README.md</filename>
@@ -262,7 +262,7 @@
       <filename>hpxml_schematron/EPvalidator.xml</filename>
       <filetype>xml</filetype>
       <usage_type>resource</usage_type>
-      <checksum>D9926CC4</checksum>
+      <checksum>38897339</checksum>
     </file>
     <file>
       <filename>hpxml_schematron/iso-schematron.xsd</filename>
@@ -280,7 +280,7 @@
       <filename>hvac_sizing.rb</filename>
       <filetype>rb</filetype>
       <usage_type>resource</usage_type>
-      <checksum>C47248F9</checksum>
+      <checksum>C1BA6300</checksum>
     </file>
     <file>
       <filename>lighting.rb</filename>
@@ -496,7 +496,7 @@
       <filename>test_enclosure.rb</filename>
       <filetype>rb</filetype>
       <usage_type>test</usage_type>
-      <checksum>D48D2FA1</checksum>
+      <checksum>925E05C1</checksum>
     </file>
     <file>
       <filename>test_generator.rb</filename>
@@ -562,7 +562,7 @@
       <filename>test_validation.rb</filename>
       <filetype>rb</filetype>
       <usage_type>test</usage_type>
-      <checksum>84F9B6C3</checksum>
+      <checksum>85662D0F</checksum>
     </file>
     <file>
       <filename>test_water_heater.rb</filename>

HPXMLtoOpenStudio/resources/geometry.rb

@@ -424,6 +424,14 @@ def self.get_temperature_scheduled_space_values(location)
                outdoor_weight: 0.0,
                ground_weight: 1.0,
                f_regain: 0.83 } # From LBNL's "Technical Background for default values used for Forced Air Systems in Proposed ASHRAE Standard 152P"
+    elsif location == HPXML::LocationManufacturedHomeBelly
+      # From LBNL's "Technical Background for default values used for Forced Air Systems in Proposed ASHRAE Standard 152P"
+      # 3.5 Manufactured House Belly Pan Temperatures
+      return { temp_min: nil,
+               indoor_weight: 1.0,
+               outdoor_weight: 0.0,
+               ground_weight: 0.0,
+               f_regain: 0.62 }
     end
     fail "Unhandled location: #{location}."
   end