Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move static VRF variables to namespace #8339

Closed
wants to merge 5 commits into from
Closed

Move static VRF variables to namespace #8339

wants to merge 5 commits into from

Conversation

jmythms
Copy link
Contributor

@jmythms jmythms commented Oct 13, 2020 •
edited
Loading

Pull request overview

  • Partially fixes Refactor VRF static timing variables #7729
  • This moves the static variables in the HVACVariableRefrigerantFlow.cc file to the namespace. Multiple condensers might still not work. The HRTime and HRTimer variables are still in the code.

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@jmythms jmythms added the Defect Includes code to repair a defect in EnergyPlus label Oct 13, 2020
@jmythms jmythms added this to the EnergyPlus Future milestone Oct 13, 2020
@jmythms jmythms self-assigned this Oct 13, 2020
jmythms
jmythms commented Oct 14, 2020
View reviewed changes
src/EnergyPlus/HVACVariableRefrigerantFlow.cc
Comment on lines +223 to +225
Real64 CurrentEndTime; // end time of current time step
Real64 CurrentEndTimeLast; // end time of last time step
Real64 TimeStepSysLast; // system time step on last time step
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The three variables are not initialized.

The static variables in the original code were not initialized as well, so I am not sure if this is ok.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine without initial values unless it's complaining about them being used before being initialized. That would need to be corrected.

@jmythms
Hotfix #7723 revert + Add flag to reset CurrentEndTimeLast when InitV…
469d49d 
…RF is not called

The unit test will work without Hotfix #7723.

Not sure if multiple condensors will work.
The HRTime, HRTimer variables still exist.
@jmythms
Merge branch 'develop' into Pull-static-variables-to-namespace
ffef488
@jmythms jmythms marked this pull request as ready for review October 14, 2020 19:42
@mitchute
Copy link
Collaborator

@Myoldmopar CI didn't pick this up for some reason. Is there any way to restart it? Or do we just bump it again with another minor change?

@jmythms jmythms closed this Oct 16, 2020
@jmythms jmythms deleted the Refactor-VRF-static-timing-variables-#7729 branch October 16, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchute mitchute mitchute left review comments

Assignees

@jmythms jmythms

Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Milestone
EnergyPlus 9.5.0
Development

Successfully merging this pull request may close these issues.

Refactor VRF static timing variables
2 participants
@jmythms @mitchute