Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coil refactor baseline - add new unitarysystem testfiles plus one bugfix #7785

Merged
merged 11 commits into from
Feb 19, 2020

Conversation

mjwitte
Copy link
Contributor

@mjwitte mjwitte commented Feb 18, 2020

Pull request overview

  • Fixes ??? not sure if it's logged as a defect
  • Add six new UnitarySystem_* testfiles in preparation for DX coil refactor

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@mjwitte mjwitte added the Refactoring Includes code changes that don't change the functionality of the program, just perform refactoring label Feb 18, 2020
@Myoldmopar
Copy link
Member

I don't understand the EDD diffs. We didn't touch that example file, and we didn't touch any of the code that should affect that.

Upon further investigation, those diffs show lines added that report uninitialized EMS variables and also some EMS divide by zeroes. The file isn't failing though, and there are multiple divide by zero messages in there, and a ton of uninitialized variables.

Unknown. And unrelated. I'm moving forward with merging this.

@Myoldmopar Myoldmopar merged commit 8393dfc into NREL:develop Feb 19, 2020
@Myoldmopar Myoldmopar deleted the CoilRefactorBaseline branch February 19, 2020 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactoring Includes code changes that don't change the functionality of the program, just perform refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants