Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require WindowMaterial:ComplexShade Emissivity to be >0 #7708

Merged

Conversation

LipingWang
Copy link
Contributor

@LipingWang LipingWang commented Jan 23, 2020

Pull request overview

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

NREL#7698
Change the minimum requirement of the emissivity (Front and Back ) to be greater than zero rather than zero in Energy+.idd.in.
@mjwitte mjwitte added Defect Includes code to repair a defect in EnergyPlus IDDChange Code changes impact the IDD file (cannot be merged after IO freeze) labels Jan 23, 2020
@mjwitte mjwitte changed the title Update Energy+.idd.in Require WindowMaterial:ComplexShade Emissivity to be >0 Jan 23, 2020
@mjwitte mjwitte added this to the EnergyPlus 9.3.0 milestone Jan 25, 2020
@mjwitte mjwitte requested a review from mitchute February 7, 2020 23:08
@mitchute
Copy link
Collaborator

mitchute commented Feb 8, 2020

@LipingWang the documentation needs to be updated:

The front emissivity of the shading layer. Minimum value: 0. Maximum value: 1. Default: 0.90.

The back emissivity of the shading layer. Minimum value: 0. Maximum value: 1. Default: 0.90.

Once you have corrected that, please merge in develop on more time.

Updated the file "group-surface-construction-elements.tex" in the folder doc\input-output-reference\src\overview.
@mitchute
Copy link
Collaborator

mitchute commented Feb 8, 2020

Not expecting any problems from the last VS build since it's been always been clean. Merging.

@mitchute mitchute merged commit b1c11ff into NREL:develop Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus IDDChange Code changes impact the IDD file (cannot be merged after IO freeze)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WindowMaterial:ComplexShade- the range of emissivity in the idd
8 participants