Corrected CapFTemp curve index used in multi-speed DX coils for capacity sizing #7626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nigusse
commented
Nov 20, 2019
| @@ -14876,7 +14876,7 @@ namespace DXCoils { | |||
| (SELECT_CASE_var == CoilDX_HeatingEmpirical) || (SELECT_CASE_var == CoilDX_CoolingTwoStageWHumControl)) { | |||
| CapFTCurveIndex = DXCoil(CoilIndex).CCapFTemp(1); | |||
| } else if ((SELECT_CASE_var == CoilDX_MultiSpeedCooling) || (SELECT_CASE_var == CoilDX_MultiSpeedHeating)) { | |||
| CapFTCurveIndex = DXCoil(CoilIndex).MSCCapFTemp(1); | |||
| CapFTCurveIndex = DXCoil(CoilIndex).MSCCapFTemp(DXCoil(CoilIndex).NumOfSpeeds); | |||
There was a problem hiding this comment.
DX coils use the maximum speed for rated design sizing. Thus the curve index used for rated design capacity adjustment should point to the maximum speed curve, instead of the lowest speed.
Myoldmopar
approved these changes
Jan 8, 2020
There was a problem hiding this comment.
This is quite good to go. CI is fully green, the fix is obvious, and the unit test captures the behavior. Nice @Nigusse, thank you.
| @@ -14876,7 +14876,7 @@ namespace DXCoils { | |||
| (SELECT_CASE_var == CoilDX_HeatingEmpirical) || (SELECT_CASE_var == CoilDX_CoolingTwoStageWHumControl)) { | |||
| CapFTCurveIndex = DXCoil(CoilIndex).CCapFTemp(1); | |||
| } else if ((SELECT_CASE_var == CoilDX_MultiSpeedCooling) || (SELECT_CASE_var == CoilDX_MultiSpeedHeating)) { | |||
| CapFTCurveIndex = DXCoil(CoilIndex).MSCCapFTemp(1); | |||
| CapFTCurveIndex = DXCoil(CoilIndex).MSCCapFTemp(DXCoil(CoilIndex).NumOfSpeeds); | |||
| Real64 PeakCoilCoolingLoad = 10000.0; | ||
| Real64 NominalCoolingDesignCapacity_lowestSpeed = PeakCoilCoolingLoad / TotCapTempModFac_lowestSpeed; | ||
| Real64 NominalCoolingDesignCapacity_designSpeed = PeakCoilCoolingLoad / TotCapTempModFac_designSpeed; | ||
| EXPECT_DOUBLE_EQ(9520.5999254239905, NominalCoolingDesignCapacity_lowestSpeed); |
There was a problem hiding this comment.
Unit test that exercises the results. Awesome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Reviewer
This will not be exhaustively relevant to every PR.