Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ideal loads heating sizing with outdoor air #7472

Merged
merged 2 commits into from
Aug 26, 2019
Merged

Fix ideal loads heating sizing with outdoor air #7472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22c9b92
Fix ideal load heating sizing with OA
mjwitte Aug 25, 2019
87ee8e3
Fix ideal load heating sizing with OA - again
mjwitte Aug 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/EnergyPlus/PurchasedAirManager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1770,6 +1770,7 @@ namespace PurchasedAirManager {
}
} else {
TempSize = PurchAir(PurchAirNum).MaxHeatSensCap;
ZoneEqSizing(CurZoneEqNum).OAVolFlow = FinalZoneSizing(CurZoneEqNum).MinOA;
ZoneHeatingOnlyFan = true;
PrintFlag = false;
RequestSizing(CompType, CompName, SizingMethod, SizingString, TempSize, PrintFlag, RoutineName);
Expand Down Expand Up @@ -1855,6 +1856,7 @@ namespace PurchasedAirManager {
}
} else {
ZoneCoolingOnlyFan = true;
ZoneEqSizing(CurZoneEqNum).OAVolFlow = FinalZoneSizing(CurZoneEqNum).MinOA;
PrintFlag = false;
TempSize = PurchAir(PurchAirNum).MaxCoolTotCap;
RequestSizing(CompType, CompName, SizingMethod, SizingString, TempSize, PrintFlag, RoutineName);
Expand Down
73 changes: 56 additions & 17 deletions tst/EnergyPlus/unit/PurchasedAirManager.unit.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,23 +149,20 @@ TEST_F(EnergyPlusFixture, SizePurchasedAirTest_Test1)
DataEnvironment::StdRhoAir = 1.0; // Prevent divide by zero in ReportSizingManager
ZoneEqSizing(CurZoneEqNum).SizingMethod.allocate(24);
CurSysNum = 0;
ZoneHVACSizing.allocate(1);
ZoneHVACSizing(1).CoolingSAFMethod = SupplyAirFlowRate;
ZoneHVACSizing(1).HeatingSAFMethod = SupplyAirFlowRate;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaned out some unnecessary things in the existing unit test.


ZoneEqSizing(CurZoneEqNum).AirVolFlow = 0.0;
FinalZoneSizing.allocate(1);
FinalZoneSizing(CurZoneEqNum).MinOA = 0.0;
FinalZoneSizing(CurZoneEqNum).OutTempAtHeatPeak = 5.0;
FinalZoneSizing(CurZoneEqNum).DesHeatVolFlow = 1.0;
ZoneEqSizing(CurZoneEqNum).HeatingAirVolFlow = 1.0;
FinalZoneSizing(CurZoneEqNum).DesHeatCoilInTemp = 30.0;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unit test shouldn't be setting ZoneEqSizing - the component sizing function should be doing that.

FinalZoneSizing(CurZoneEqNum).ZoneTempAtHeatPeak = 30.0;
FinalZoneSizing(CurZoneEqNum).HeatDesTemp = 80.0;
FinalZoneSizing(CurZoneEqNum).HeatDesHumRat = 0.008;
FinalZoneSizing(CurZoneEqNum).DesHeatMassFlow = FinalZoneSizing(CurZoneEqNum).DesHeatVolFlow * DataEnvironment::StdRhoAir;

FinalZoneSizing(CurZoneEqNum).DesCoolVolFlow = 2.0;
ZoneEqSizing(CurZoneEqNum).CoolingAirVolFlow = 2.0;
FinalZoneSizing(CurZoneEqNum).DesCoolCoilInTemp = 60.0;
FinalZoneSizing(CurZoneEqNum).OutTempAtCoolPeak = 70.0;
FinalZoneSizing(CurZoneEqNum).CoolDesTemp = 50.0;
FinalZoneSizing(CurZoneEqNum).CoolDesHumRat = 0.008;
FinalZoneSizing(CurZoneEqNum).DesCoolCoilInHumRat = 0.010;
Expand All @@ -179,7 +176,6 @@ TEST_F(EnergyPlusFixture, SizePurchasedAirTest_Test1)
PurchAirNumericFields(PurchAirNum).FieldNames(7) = "Maximum Cooling Air Flow Rate";
PurchAirNumericFields(PurchAirNum).FieldNames(8) = "Maximum Total Cooling Capacity";

ZoneEqSizing(CurZoneEqNum).SizingMethod(HeatingAirflowSizing) = SupplyAirFlowRate;
ZoneSizingRunDone = true;

PurchAir(PurchAirNum).HeatingLimit = LimitFlowRateAndCapacity;
Expand All @@ -191,22 +187,65 @@ TEST_F(EnergyPlusFixture, SizePurchasedAirTest_Test1)
PurchAir(PurchAirNum).cObjectName = "ZONEHVAC:IDEALLOADSAIRSYSTEM";
PurchAir(PurchAirNum).Name = "Ideal Loads 1";

// Need this to prevent crash in RequestSizing
UnitarySysEqSizing.allocate(10);

SizePurchasedAir(PurchAirNum);
EXPECT_DOUBLE_EQ(1.0, PurchAir(PurchAirNum).MaxHeatVolFlowRate);
EXPECT_NEAR(50985.58, PurchAir(PurchAirNum).MaxHeatSensCap, 0.1);
EXPECT_DOUBLE_EQ(2.0, PurchAir(PurchAirNum).MaxCoolVolFlowRate);
EXPECT_NEAR(30844.14, PurchAir(PurchAirNum).MaxCoolTotCap, 0.1);
}

TEST_F(EnergyPlusFixture, SizePurchasedAirTest_Test2)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a second unit test with OA.

{

int PurchAirNum = 1;
ZoneEqSizing.allocate(1);
CurZoneEqNum = 1;
DataEnvironment::StdRhoAir = 1.0; // Prevent divide by zero in ReportSizingManager
ZoneEqSizing(CurZoneEqNum).SizingMethod.allocate(24);
CurSysNum = 0;

FinalZoneSizing.allocate(1);
FinalZoneSizing(CurZoneEqNum).MinOA = 0.5;
FinalZoneSizing(CurZoneEqNum).OutTempAtHeatPeak = 5.0;
FinalZoneSizing(CurZoneEqNum).DesHeatVolFlow = 1.0;
FinalZoneSizing(CurZoneEqNum).DesHeatCoilInTemp = 30.0; // this isn't used so don't change it
FinalZoneSizing(CurZoneEqNum).ZoneTempAtHeatPeak = 30.0;
FinalZoneSizing(CurZoneEqNum).HeatDesTemp = 80.0;
FinalZoneSizing(CurZoneEqNum).HeatDesHumRat = 0.008;
FinalZoneSizing(CurZoneEqNum).DesHeatMassFlow = FinalZoneSizing(CurZoneEqNum).DesHeatVolFlow * DataEnvironment::StdRhoAir;

FinalZoneSizing(CurZoneEqNum).DesCoolVolFlow = 2.0;
FinalZoneSizing(CurZoneEqNum).DesCoolCoilInTemp = 65.0; // this is used, so make it higher
FinalZoneSizing(CurZoneEqNum).OutTempAtCoolPeak = 70.0; // this is not currently used for cooling
FinalZoneSizing(CurZoneEqNum).CoolDesTemp = 50.0;
FinalZoneSizing(CurZoneEqNum).CoolDesHumRat = 0.008;
FinalZoneSizing(CurZoneEqNum).DesCoolCoilInHumRat = 0.010;
FinalZoneSizing(CurZoneEqNum).DesCoolMassFlow = FinalZoneSizing(CurZoneEqNum).DesCoolVolFlow * DataEnvironment::StdRhoAir;

PurchAir.allocate(10);
PurchAirNumericFields.allocate(10);
PurchAirNumericFields(PurchAirNum).FieldNames.allocate(8);
PurchAirNumericFields(PurchAirNum).FieldNames(5) = "Maximum Heating Air Flow Rate";
PurchAirNumericFields(PurchAirNum).FieldNames(6) = "Maximum Sensible Heating Capacity";
PurchAirNumericFields(PurchAirNum).FieldNames(7) = "Maximum Cooling Air Flow Rate";
PurchAirNumericFields(PurchAirNum).FieldNames(8) = "Maximum Total Cooling Capacity";

ZoneEqSizing(CurZoneEqNum).SizingMethod.deallocate();
ZoneEqSizing.deallocate();
ZoneHVACSizing.deallocate();
FinalZoneSizing.deallocate();
PurchAir.deallocate();
PurchAirNumericFields.deallocate();
UnitarySysEqSizing.deallocate();
ZoneSizingRunDone = true;

PurchAir(PurchAirNum).HeatingLimit = LimitFlowRateAndCapacity;
PurchAir(PurchAirNum).MaxHeatVolFlowRate = AutoSize;
PurchAir(PurchAirNum).MaxHeatSensCap = AutoSize;
PurchAir(PurchAirNum).CoolingLimit = LimitFlowRateAndCapacity;
PurchAir(PurchAirNum).MaxCoolVolFlowRate = AutoSize;
PurchAir(PurchAirNum).MaxCoolTotCap = AutoSize;
PurchAir(PurchAirNum).cObjectName = "ZONEHVAC:IDEALLOADSAIRSYSTEM";
PurchAir(PurchAirNum).Name = "Ideal Loads 1";

SizePurchasedAir(PurchAirNum);
EXPECT_DOUBLE_EQ(1.0, PurchAir(PurchAirNum).MaxHeatVolFlowRate);
EXPECT_NEAR(63731.97, PurchAir(PurchAirNum).MaxHeatSensCap, 0.1); // larger than test 1 above
EXPECT_DOUBLE_EQ(2.0, PurchAir(PurchAirNum).MaxCoolVolFlowRate);
EXPECT_NEAR(41078.43, PurchAir(PurchAirNum).MaxCoolTotCap, 0.1); // larger than test1 above
}

TEST_F(EnergyPlusFixture, IdealLoadsAirSystem_GetInput)
Expand Down