Resolve Site:GroundDomain:* Issues with R-Only Materials #7446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Site:GroundDomain:* objects require insulation but using a no mass material for the insulation causes EnergyPlus to crash. This code adds a trap on reading input to flag this problem and force the user to fix this. This check needs to be made in four different places so the fix includes two generic simple subroutines that check to see if there is a problem and then throw an error message if there was a problem. Testing indicates the error message is being produce when it should and not being sent to the err file if things are fine.
This commit includes a unit test for this fix, documentation changes to reinforce the requirement that no-mass materials may not be used for slab and basement insulation, and the renaming of one of the new functions to a clearer name.
Myoldmopar
approved these changes
Aug 27, 2019
| if (SiteGroundDomainUsingNoMassMat(thisDomain.HorizInsThickness,thisDomain.HorizInsMaterialNum)) { | ||
| ErrorsFound = true; | ||
| SiteGroundDomainNoMassMatError(DataIPShortCuts::cAlphaFieldNames(8),DataIPShortCuts::cAlphaArgs(8),thisDomain.Name); | ||
| } |
There was a problem hiding this comment.
At first I was going to suggest that the no-mass check function and the error function should be methods on the domain class itself so that you didn't have to pass args. However, I see now that the function would need to switch based on which condition it is checking, and would be overly complicated. On the other hand, in this case, the function is super simple and you just pass in a couple arguments and it is all good.
|
Verified the NaN defect with develop branch locally. Verified this branch provides a meaningful error message instead and gracefully exits. I also fixed a couple small things that I am pushing up now and this branch will be merged. Thanks @RKStrand |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
EnergyPlus was failing during situations where a user chose a "no mass" material (defined by only an R-Value) as the insulation material for the underground slab or basement model. This is tied to the fact that the model uses the thickness of the insulation material to define a solution mesh. The solution here was to not allow users to use no mass materials for horizontal or vertical insulation in these slab or basement models and require them to using a regular material which includes a designation of thickness, specific heat, etc. The new error message alerts the user to the need to use a regular material rather than a no mass material. This resolve GitHub Issue #7269.
Work Checklist
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Review Checklist
This will not be exhaustively relevant to every PR.