Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the OutputVariables reference issue for cooling coils for #6767 and #7440 #7439

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

YanfeiNREL
Copy link
Contributor

@YanfeiNREL YanfeiNREL commented Jul 31, 2019

Fix issue for #6767.
The Output Variables of two coils are referencing the cooling coils, instead of heating coils:
Coil:WaterHeating:AirToWaterHeatPump:Pumped
Coil:WaterHeating:AirToWaterHeatPump:Wrapped.

Heating Coils have no sensible/latent calculated, therefore the Output
Variables are updated accordingly for the two coils.

Pull request overview

Please change this line to a description of the pull request, with useful supporting information including whether it is a new feature, or fixes a defect, a cross reference to any defects addressed in this PR, the type of changes to be made, and whether diffs are expected/justified based on this change.

Work Checklist

  • Defect: This pull request repairs a github defect issue. The github issue should be referenced in the PR description

Review Checklist

This will not be exhaustively relevant to every PR.

  • Functional code review (it has to work!)
  • [ X ] If defect, results of running current develop vs this branch should exhibit the fix
  • CI status: all green or justified
  • Performance: CI Linux results include performance check
  • Unit Test(s)
  • C++ checks:
    • Argument types
    • If any virtual classes, ensure virtual destructor included, other things
  • IDD changes:
    • Verify naming conventions and styles, memos and notes and defaults
    • Open windows IDF Editor with modified IDD to check for errors
    • If transition, add to input rules file for interfaces
    • If transition, add transition source
    • If transition, update idfs
  • If new idf included, locally check the err file and other outputs
  • Required documentation updates?
  • ExpandObjects changes?
  • If output changes, including tabular output structure, add to output rules file for interfaces

instead of heating coils:
Coil:WaterHeating:AirToWaterHeatPump:Pumped
Coil:WaterHeating:AirToWaterHeatPump:Wrapped.

Heating Coils have no sensible/latent calculated, therefore the Output
Variables are updated accordingly for the two coils.
@YanfeiNREL YanfeiNREL requested review from Myoldmopar and mjwitte July 31, 2019 21:41
@mjwitte mjwitte added the Defect Includes code to repair a defect in EnergyPlus label Jul 31, 2019
@mjwitte mjwitte added this to the EnergyPlus 9.2.0 milestone Aug 5, 2019
@mjwitte
Copy link
Contributor

mjwitte commented Aug 7, 2019

This is on hold until the discussion in #6767 comes to some conclusion. Then this PR can be modified accordingly.

@YanfeiNREL YanfeiNREL changed the title Fix the OutputVariables reference issue for cooling coils @6767 Fix the OutputVariables reference issue for cooling coils for #6767 and #7440 Aug 16, 2019
@Myoldmopar Myoldmopar merged commit 0d86e64 into develop Aug 22, 2019
@Myoldmopar Myoldmopar deleted the Ref_heatingcoils_6767 branch August 22, 2019 02:59
@rraustad
Copy link
Contributor

This got merged? I thought this was on hold and then in #6767 decided there should be no change.

@Myoldmopar
Copy link
Member

Good call. If we need to revert this out, we can definitely do it.

@YanfeiNREL
Copy link
Contributor Author

I updated the DOC of [EnergyPlus Input/Output Reference] with the explanations why we call it Cooling Coil. This is a minimal effort to fix the issue in #6767 and #7440. This is not the best solution. If you have a better solution, i would love to reopen it and work on it. @rraustad Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants