-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows ZoneHVAC:EvaporativeCooler unit to cycle #7319
Merged
Merged
Changes from 15 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
51599e7
Refactor CalcZoneEvaporativeCoolerUnit function
Nigusse 1ec83b2
Removed unused variable and parameter
Nigusse 1ab2988
Allowed ZoneHVACEvapCooler cycling
Nigusse b57d690
Merge branch 'develop' into 166330897_Issue6707
Nigusse 69c0402
Merge branch 'develop' into 166330897_Issue6707
Nigusse 6c25607
Added Unit Tests
Nigusse e749dd6
corrected failed unit test
Nigusse f985636
Merge branch 'develop' into 166330897_Issue6707
Nigusse 74e6a1a
Updated ZoneEvapUnit Structure
Nigusse 498e95e
Merge branch 'develop' into 166330897_Issue6707
Nigusse 13302b6
fan type restriction for zone evap coolers
Nigusse 3ff729a
revised allowed fan types.
Nigusse 9ab09e8
allow evap unit to cycle for all fan types
Nigusse 55ef3e4
evap cooler, power and water use
Nigusse 63d53b5
Updated Evap Cooler IO Ref Document
Nigusse 0d23eeb
Merge remote-tracking branch 'remotes/origin/develop' into 166330897_…
mjwitte 130d322
Addressed review comments
Nigusse 065af28
Merge remote-tracking branch 'remotes/origin/develop' into 166330897_…
mjwitte cdf25ef
Modified Zone Evap Cooler Water Pump Power Calc
Nigusse 43a9545
modified Sim Evap Cooler, replaced optional argument with default
Nigusse cf4bb3e
modified Sim Evap Cooler, replaced optional argument with default
Nigusse f0d6887
Merge branch '166330897_Issue6707' of https://github.com/NREL/EnergyP…
Nigusse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this control type, seems it should read "If there is a cooling load (and the unit is available), then the unit is cycled at the design air mass flow rate such that it meets the current cooling load . . . " (essentially merging the last sentence with the second sentence).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated as suggested.