Tag cooling panel as valid branch equipment in IDD

[mjwitte]

Pull request overview

ZoneHVAC:CoolingPanel:RadiantConvective:Water was not tagged a valid branch equipment in the IDD. This cause IDF Editor (and possibly other tools) to show ZoneHVAC:CoolingPanel:RadiantConvective:Water as invalid on a branch.

Noticed as part of helpdesk ticket 15143.

To test, open 5ZoneCoolingPanelBaseboard.idf in v9.1 IDFEditor and select View --> Validity Check. The cooling panel will be noted as an invalid branch object. With this fix, the validity check should be empty (no errors).

Work Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• At least one of the following appropriate labels must be added to this PR to be consumed into the changelog:
  • Defect: This pull request repairs a github defect issue. The github issue should be referenced in the PR description
  • Refactoring: This pull request includes code changes that don't change the functionality of the program, just perform refactoring
  • NewFeature: This pull request includes code to add a new feature to EnergyPlus
  • Performance: This pull request includes code changes that are directed at improving the runtime performance of EnergyPlus
  • DoNoPublish: This pull request includes changes that shouldn't be included in the changelog

Review Checklist

This will not be exhaustively relevant to every PR.

• Functional code review (it has to work!)
• If defect, results of running current develop vs this branch should exhibit the fix
• CI status: all green or justified
• Performance: CI Linux results include performance check
• Unit Test(s)
• C++ checks:
  • Argument types
  • If any virtual classes, ensure virtual destructor included, other things
• IDD changes:
  • Verify naming conventions and styles, memos and notes and defaults
  • Open windows IDF Editor with modified IDD to check for errors
  • If transition, add to input rules file for interfaces
  • If transition, add transition source
  • If transition, update idfs
• If new idf included, locally check the err file and other outputs
• Required documentation updates?
• ExpandObjects changes?
• If output changes, including tabular output structure, add to output rules file for interfaces

[nrel-bot-2]

@mjwitte it has been 14 days since this pull request was last updated.

[nrel-bot-2c]

@mjwitte it has been 7 days since this pull request was last updated.

[Myoldmopar]

There wasn't an issue for this, right?

[mjwitte]

@Myoldmopar Correct - no separate issue.