Fix CppCheck Build

[Myoldmopar]

Pull request overview

CppCheck is suddenly not building on our GHA tests. It looks like GitHub just pushed ubuntu-latest from 22.04 to 24.04. I confirmed that locally on 24.04 I also get a build failure with CppCheck 2.10. I could have fallen back to ubuntu-22.04 for our GHA builds, but I decided to instead just update our CppCheck version. I can build 2.15.0 fine locally, so I pointed our GHA tests to that latest version. If this is green and CppCheck is producing good results, this should be good to go.

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[Myoldmopar]

OK, CppCheck is now working happily again. I'm able to use the Ubuntu 24 cppcheck version so we don't have to manually build it anymore. I disabled the folder caching, but it still ran in just 10ish minutes from scratch. I almost went down the rabbit hole of cleaning up all our cppcheck arguments, but held off. For now. This can merge to get cppcheck working again on everyone's commits.