Fix #10355 - Correctly Set up Zone Internal Gains when Refrigeration:CompressorRack serves a Refrigeration:WalkIn object with "Zone" Heat Transfer Location #10525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CompressorRack serves a Refrigeration:WalkIn object with "Zone" Heat Transfer Location
jmarrec
commented
May 27, 2024
| @@ -197,6 +197,7 @@ set(test_src | |||
| Psychrometrics.unit.cc | |||
| Pumps.unit.cc | |||
| PurchasedAirManager.unit.cc | |||
| RefrigeratedCase.unit.cc | |||
There was a problem hiding this comment.
It's quite scary that there was zero unit test for any Refrigeration objects...
| ; !- Zone Equipment Sequential Heating Fraction Schedule Name 1 | ||
| )IDF"; | ||
|
|
||
| TEST_F(EnergyPlusFixture, RefrigeratedRackWithCaseInZone) |
There was a problem hiding this comment.
So I've set up 4 unit tests:
- CompressorRack references a Case, directly
- CompressorRack references a WalkIn, directly (failed initially)
- CompressorRack references only a WalkIn, via a CaseAndWalkInList (failed initially)
- CompressorRack references both a Walkin and a Case, via a CaseAndWalkinList (Walkin first, then case).
Comment on lines
+8637
to
+8639
| // If CoilFlag is true and Location is Zone, GetRefrigerationInput ensures you must have a Heat Rejection Zone provided already | ||
| SetupZoneInternalGain(state, | ||
| RefrigCase(rack.CaseNum(1)).ActualZoneNum, | ||
| rack.HeatRejectionZoneNum, |
There was a problem hiding this comment.
In this case that means NumCoils > 0, Get input routine will throw if you don't have a HeatRejectionZone, so safe to use
Comment on lines
+8798
to
+8809
|
|
||
| // if Location is Zone, GetRefrigerationInputEither checks that you have at least one load and that either: | ||
| // * You have only cases, and they must be all in the same zone | ||
| // * Or you must have a Heat Rejection Zone provided | ||
| int rackZoneNum = -1; | ||
| if (rack.HeatRejectionZoneNum > 0) { | ||
| rackZoneNum = rack.HeatRejectionZoneNum; | ||
| } else { | ||
| rackZoneNum = RefrigCase(rack.CaseNum(1)).ActualZoneNum; | ||
| } | ||
| SetupZoneInternalGain(state, | ||
| RefrigCase(rack.CaseNum(1)).ActualZoneNum, | ||
| rackZoneNum, |
There was a problem hiding this comment.
When CoilFlag is not set, NumCoils == 0, and either you have NumWalkIns > 0, in which case you MUST have a heat rejection zone. Otherwise that means NumCases > 0 and it's enforced that all of them must be in the same zone.
(It also enforces that NumCoils + NumWalkIns + NumCases > 0, so we know there is a load)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
I have ran the Defect file (which I hosted on EnergyPlusDevSupport/DefectFiles/10000s/10355) before and after fix. Confirmed the segfault before, and completion after.
Pull Request Author
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Reviewer
This will not be exhaustively relevant to every PR.