Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use QtIFW on Windows #7396

Closed
3 tasks
Myoldmopar opened this issue Jul 17, 2019 · 1 comment · Fixed by #7399
Closed
3 tasks

Use QtIFW on Windows #7396

Myoldmopar opened this issue Jul 17, 2019 · 1 comment · Fixed by #7399
Assignees
Labels
Defect Includes code to repair a defect in EnergyPlus

Comments

@Myoldmopar
Copy link
Member

Myoldmopar commented Jul 17, 2019

Issue overview

We recently moved from PackageMaker to QtIFW on Mac. The CI systems are currently having an issue with building NSIS packages, and after a quick test, it looks like moving to QtIFW on Windows may be a great step forward on there too. I have already installed QtIFW on our Windows CI box and created a successful test build. We just need to do some polishing to make the installer look nice.

Details

Some additional details for this issue (if relevant):

  • Platform (Operating system, version)
  • Version of EnergyPlus (if using an intermediate build, include SHA)
  • Unmethours link or helpdesk ticket number

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Defect file added (list location of defect file here)
  • Ticket added to Pivotal for defect (development team task)
  • Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)
@Myoldmopar Myoldmopar added the Defect Includes code to repair a defect in EnergyPlus label Jul 17, 2019
@jmarrec
Copy link
Contributor

jmarrec commented Jul 18, 2019

@kbenne you wrote the NSIS stuff (https://github.com/jmarrec/EnergyPlus/blob/develop/cmake/CMakeCPackOptions.cmake.in#L67) . I'd like to make sure I'm understanding something correctly:

if 64bit (\${If} \${RunningX64}) you copy DLLs to C:\Windows\SysWOW64, and otherwise to C:\Windows\System32

Despite the names, System32 is full of 64-bit files and SysWOW64 is full of 32-bit files. I assume System32 is 32bit on a 32 bit system. So I'm concluding that the DLLs you are copying are all 32-bits. Is that correct? Or is this a confusion due to the (poorly-chosen) naming convention of windows?

Myoldmopar added a commit that referenced this issue Aug 20, 2019
hongyuanjia pushed a commit to hongyuanjia/eplusr that referenced this issue Oct 16, 2019
See NREL/EnergyPlus#7396

From EnergyPlus v9.2, the installer will be packaged using QtIFW instead of NSIS. Right now, QtIFW did not support silent installation. I follow this thread to write a controller script to achieve this.

https://stackoverflow.com/questions/25105269/silent-install-qt-run-installer-on-ubuntu-server
hongyuanjia pushed a commit to hongyuanjia/eplusr that referenced this issue Oct 17, 2019
* Add support for EnergyPlus v9.2.

* Support v9.2 Windows installer

See NREL/EnergyPlus#7396

From EnergyPlus v9.2, the installer will be packaged using QtIFW instead of NSIS. Right now, QtIFW did not support silent installation. I follow this thread to write a controller script to achieve this.

https://stackoverflow.com/questions/25105269/silent-install-qt-run-installer-on-ubuntu-server

* Add transition for v9.2.

* Update NEWS.

* Fix tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants