sqlite TimestepType is backwards

[mjwitte]

Issue overview

Noticed in various sqlite tables that TimestepType is backwards. Zone timestep variables are tagged as "HVAC System" and HVAC variables are tagged as "Zone".

SQLite::timestepTypeName is where the error is.

OutputProcessor::ValidateIndexType shows the correct mapping. 1=Zone, 2=HVAC.

Details

Some additional details for this issue (if relevant):

• Version of EnergyPlus v9.1-f43e577
• Noticed this while looking at sql tables in Excel using method given in this bldg-sim post

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Defect file added - any example file with sql output, e.g. RefBldgLargeOfficeNew2004_Chicago
• Ticket added to Pivotal for defect (development team task)
• Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)

[jmarrec]

Instead of just fixing the method, I propose to use a single enum throughout energyplus to avoid this kind of mistake down the line and make it clearer as to what's happening.

This is going to involve a lot of file changes, but I'm willing to give it a shot.

[mjwitte]

Yes, that would be good to do at some point. But given where we are in the release cycle, it seems best to just fix this and plan for an enum pass through the code shortly after the next release when we have fewer open PRs.

[jmarrec]

@mjwitte I did see your comment, but when I was already about 70% in adding the enum... Tests results in #7415 seem pretty clean though, so hopefully this won't be too much of a hassle reviewing.
Just fixing this the "easy" way would also pose the same problems of having to modify the existing unit tests etc.

[mjwitte]

Well, we'll have to see how it looks. @Myoldmopar will make the call whether this can go forward now or wait until after release.