Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve waste heat function handling for Coil:Cooling:DX:MultiSpeed and Coil:Heating:DX:MultiSpeed #5162

Closed
lgu1234 opened this issue Sep 1, 2015 · 6 comments
Closed

Improve waste heat function handling for Coil:Cooling:DX:MultiSpeed and Coil:Heating:DX:MultiSpeed #5162

lgu1234 opened this issue Sep 1, 2015 · 6 comments
Assignees
@lgu1234
Labels
SeverityMedium This defect is medium severity, indicating moderate impact and generally no workaround available

Comments

@lgu1234
Copy link
Contributor

lgu1234 commented Sep 1, 2015

This issue is a continuous fix of #4536 (Coil:Cooling:DX:MultiSpeed requires Waste Heat Function of Temperature Curve Name when it should not). It suggested 3 steps to handle this issue.
1 Match IO description: when fuel is electricity, no waste heat curve check is needed. This has been fix in #4536
2 Check parent input. If no heat recovery from the parent, no need to check waste heat curve
3 If the parent has heat recovery and no waste heat curve inputs, simply use a constant value at 1.
This issue handles two remaining steps.
@lgu1234 lgu1234 added SeverityMedium This defect is medium severity, indicating moderate impact and generally no workaround available EnergyPlus labels Sep 1, 2015
@lgu1234 lgu1234 self-assigned this Sep 1, 2015
nrel-bot referenced this issue Sep 3, 2015
@Myoldmopar
Merge pull request #5151 from NREL/Autodesk_Performance
a59844c 
Autodesk performance
lgu1234 added a commit that referenced this issue Sep 8, 2015
@lgu1234
Merge branch 'develop' into 102497980-Improve-waste-heat-function-han…
6c4090d 
…dling-for-CoilCoolingDXMultiSpeed-and-CoilHeatingDXMultiSpeed-#5162

Conflicts:
	src/EnergyPlus/DXCoils.cc
	src/EnergyPlus/DXCoils.hh
@mjwitte
Copy link
Contributor

mjwitte commented Sep 13, 2015

@lgu1234 Coil:Cooling:WaterToAirHeatPump:VariableSpeedEquationFit and probably others also have waste heat fields that are required. Seems they should all be optional.

@lgu1234 lgu1234 mentioned this issue Sep 14, 2015
Merged
@lgu1234
Copy link
Contributor Author

lgu1234 commented Sep 14, 2015

@mjwitte I am going to take a look at waste heat fields and will take proper actions to make the field optional.

@mjwitte
Copy link
Contributor

mjwitte commented Sep 14, 2015

@lgu1234 Thanks. I added some defect files for the heatpump:multispeed, but not for any others. You'll need to remove some of the \required-field tags in the IDD.

@lgu1234
Copy link
Contributor Author

lgu1234 commented Sep 14, 2015

@mjwitte The \required-field tags in the fields of Speed 1 Waste Heat Function of Temperature Curve Name and Speed 2 Waste Heat Function of Temperature Curve Name in the Coil:Heating:DX:MultiSpeed have been removed. Will commit it now.

lgu1234 added a commit that referenced this issue Sep 14, 2015
@lgu1234
Merge branch 'develop' into 102497980-Improve-waste-heat-function-han…
30dc797 
…dling-for-CoilCoolingDXMultiSpeed-and-CoilHeatingDXMultiSpeed-#5162

Conflicts:
	src/EnergyPlus/DXCoils.cc
	tst/EnergyPlus/unit/DXCoils.unit.cc
@mjwitte
Copy link
Contributor

mjwitte commented Sep 14, 2015

Also the waste heat fraction fields should not be required.

nrel-bot referenced this issue Sep 14, 2015
@lgu1234
Removed the \required-field tags in the fields of Speed 1 Waste Heat …
0226a4b 
…Function of Temperature Curve Name and Speed 2 Waste Heat Function of Temperature Curve Name in the Coil:Heating:DX:MultiSpeed
nrel-bot referenced this issue Sep 14, 2015
@lgu1234
Clean up after solving conflicts
4742ab5
lgu1234 added a commit that referenced this issue Sep 15, 2015
@lgu1234
Merge branch 'develop' into 102497980-Improve-waste-heat-function-han…
7b2ea0d 
…dling-for-CoilCoolingDXMultiSpeed-and-CoilHeatingDXMultiSpeed-#5162
nrel-bot referenced this issue Sep 16, 2015
@lgu1234
Revised code to remove extra warnings and cleaned up the doc
2e01a54
mjwitte added a commit that referenced this issue Sep 16, 2015
@mjwitte
Merge remote-tracking branch 'remotes/origin/develop' into 102497980-…
6056a70 
…Improve-waste-heat-function-handling-for-CoilCoolingDXMultiSpeed-and-CoilHeatingDXMultiSpeed-#5162
nrel-bot referenced this issue Sep 16, 2015
@mjwitte
DX multispeed doc cleanup
ad1e1ef
mjwitte added a commit that referenced this issue Sep 17, 2015
@mjwitte
Merge pull request #5176 from NREL/102497980-Improve-waste-heat-funct…
0d9b058 
…ion-handling-for-CoilCoolingDXMultiSpeed-and-CoilHeatingDXMultiSpeed-#5162

102497980 improve waste heat function handling for coil cooling dx multi speed and coil heating dx multi speed #5162
@mjwitte
Copy link
Contributor

mjwitte commented Sep 17, 2015

Closed via #5176

@mjwitte mjwitte closed this as completed Sep 17, 2015
@lgu1234 lgu1234 mentioned this issue Sep 22, 2015
Closed
@lgu1234 lgu1234 mentioned this issue Feb 23, 2016
Merged
@lgu1234 lgu1234 mentioned this issue Jun 16, 2016
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lgu1234 lgu1234

Labels
SeverityMedium This defect is medium severity, indicating moderate impact and generally no workaround available
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mjwitte @lgu1234