Merge pull request #7812 from NREL/PluginInstanceIDDFix

"Urgent" IDD fix for min-fields on new Plugin Instance object
NREL · Feb 27, 2020 · ca68d45 · ca68d45 · nrel-bot-2c · Feb 27, 2020
2 parents cc126b8 + 672db85
commit ca68d45
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/idd/Energy+.idd.in b/idd/Energy+.idd.in
@@ -108243,7 +108243,7 @@ PythonPlugin:SearchPaths,
 PythonPlugin:Instance,
        \memo A single plugin to be executed during the simulation, which can contain multiple calling points
        \memo for the same class instance by overriding multiple calling point methods.
-       \min-fields 5
+       \min-fields 4
    A1, \field Name
        \required-field
        \type alpha

diff --git a/scripts/dev/generate_epJSON_schema/idd_parser.py b/scripts/dev/generate_epJSON_schema/idd_parser.py
@@ -145,6 +145,10 @@ def parse_idd(data):
             if 'memo' in obj_data:
                 root['properties'][obj_name]['memo'] = obj_data.pop('memo')
             if 'min_fields' in obj_data:
+                num_fields_with_name = len(obj_data['properties']) + 1
+                if int(obj_data['min_fields']) > num_fields_with_name:
+                    if 'extensions' not in obj_data['properties']:
+                        raise RuntimeError("Object with min-fields > num_fields. Object name = " + obj_name)
                 root['properties'][obj_name]['min_fields'] = obj_data.pop('min_fields')
             if 'extensible_size' in obj_data:
                 root['properties'][obj_name]['extensible_size'] = obj_data.pop('extensible_size')