Skip to content

Commit

Permalink
Single warning if multiple \min-fields are a problem and fix typos
Browse files Browse the repository at this point in the history
  • Loading branch information
JasonGlazer committed Jan 15, 2020
1 parent 5639b15 commit 76953b2
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
Binary file modified bin/IDFEditor/IDFEditor.exe
Binary file not shown.
11 changes: 10 additions & 1 deletion src/IDF_Editor/IDFEditMain.bas
Original file line number Diff line number Diff line change
Expand Up @@ -1974,15 +1974,24 @@ End If
End Sub


'-----------------------------------------------------------------------------
' Make sure the IDD \min-fields is less than or equal to the number of
' fields in each object
'-----------------------------------------------------------------------------
Sub checkMinFields()
Dim numfields As Integer
Dim errMessage As String
Dim i As Integer
errMessage = ""
For i = 1 To maxUsedIDDClass
numfields = 1 + IDDClassDat(i).fieldEnd - IDDClassDat(i).fieldStart
If IDDClassDat(i).minFields > numfields Then
Call MsgBox("\min-field is greater than the number of fiels in: " & IDDClassDat(i).name, vbInformation, "Warning")
errMessage = errMessage & vbCrLf & IDDClassDat(i).name
End If
Next i
If errMessage <> "" Then
Call MsgBox("\min-fields is greater than the number of fields in: " & vbCrLf & errMessage, vbInformation, "Warning")
End If
End Sub


Expand Down
2 changes: 1 addition & 1 deletion src/IDF_Editor/about.frm
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ End Sub

Private Sub Form_Load()
lblAboutEPVer.Caption = "EnergyPlus and IDD version number: " & IDDVersion
txtNotice.Text = "Copyright (c) 2000-2019 GARD Analytics, " & vbCrLf
txtNotice.Text = "Copyright (c) 2000-2020 GARD Analytics, " & vbCrLf
txtNotice.Text = txtNotice.Text & "Inc. All rights reserved." & vbCrLf
txtNotice.Text = txtNotice.Text & " " & vbCrLf
txtNotice.Text = txtNotice.Text & "The code for quick select dropdowns " & vbCrLf
Expand Down

6 comments on commit 76953b2

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FixMinFieldsAndIdfEd (JasonGlazer) - x86_64-MacOS-10.13-clang: Tests Failed (1993 of 2598 tests passed, 20 test warnings)

Messages:\n

  • 605 tests had: Table big diffs.
  • 158 tests had: EIO diffs.
  • 98 tests had: MDD diffs.
  • 100 tests had: MTD diffs.
  • 98 tests had: RDD diffs.
  • 37 tests had: ESO small diffs.
  • 45 tests had: MTR small diffs.
  • 12 tests had: BND diffs.
  • 1 test had: JSON big diffs.
  • 2 tests had: AUD diffs.
  • 4 tests had: ERR diffs.

Failures:\n

regression Test Summary

  • Passed: 65
  • Failed: 605

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FixMinFieldsAndIdfEd (JasonGlazer) - x86_64-Linux-Ubuntu-18.04-gcc-7.4: Tests Failed (2030 of 2638 tests passed, 20 test warnings)

Messages:\n

  • 608 tests had: Table big diffs.
  • 158 tests had: EIO diffs.
  • 98 tests had: MDD diffs.
  • 100 tests had: MTD diffs.
  • 98 tests had: RDD diffs.
  • 39 tests had: ESO small diffs.
  • 47 tests had: MTR small diffs.
  • 12 tests had: BND diffs.
  • 1 test had: JSON big diffs.
  • 2 tests had: AUD diffs.
  • 4 tests had: ERR diffs.

Failures:\n

regression Test Summary

  • Passed: 82
  • Failed: 608

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FixMinFieldsAndIdfEd (JasonGlazer) - x86_64-Linux-Ubuntu-18.04-cppcheck: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FixMinFieldsAndIdfEd (JasonGlazer) - x86_64-Linux-Ubuntu-18.04-custom_check: OK (11 of 11 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FixMinFieldsAndIdfEd (JasonGlazer) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-UnitTestsCoverage-Debug: OK (1256 of 1256 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FixMinFieldsAndIdfEd (JasonGlazer) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-IntegrationCoverage-Debug: OK (674 of 675 tests passed, 0 test warnings)

Failures:\n

integration Test Summary

  • Passed: 674
  • Timeout: 1

Build Badge Test Badge Coverage Badge

Please sign in to comment.