Skip to content

Commit

Permalink
add size reporting for initial size
Browse files Browse the repository at this point in the history 
flush out request to also report initial sizes. finish out all 4
chillers in PlantChillers.  reapply new pattern to files touched so far.
  • Loading branch information
@EnergyArchmage
EnergyArchmage committed Feb 5, 2015
1 parent 9e6a87a commit 5e2e584
Show file tree
Hide file tree
Showing 14 changed files with 902 additions and 477 deletions.
36 changes: 23 additions & 13 deletions src/EnergyPlus/Boilers.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -667,8 +667,8 @@ namespace Boilers {
using namespace DataSizing;
using DataPlant::PlantLoop;
using DataPlant::PlantFirstSizesOkayToFinalize;
using DataPlant::PlantReSizingCompleted;
using DataPlant::PlantSizesOkayToReport;
using DataPlant::PlantFirstSizesOkayToReport;
using DataPlant::PlantFinalSizesOkayToReport;
using FluidProperties::GetDensityGlycol;
using FluidProperties::GetSpecificHeatGlycol;
using PlantUtilities::RegisterPlantCompDesignFlow;
Expand Down Expand Up @@ -723,13 +723,18 @@ namespace Boilers {
if ( PlantFirstSizesOkayToFinalize ) {
if ( Boiler( BoilerNum ).NomCapWasAutoSized ) {
Boiler( BoilerNum ).NomCap = tmpNomCap;
if ( PlantSizesOkayToReport ) {
ReportSizingOutput( "Boiler:HotWater", Boiler( BoilerNum ).Name, "Design Size Nominal Capacity [W]", tmpNomCap );
if ( PlantFinalSizesOkayToReport ) {
ReportSizingOutput( "Boiler:HotWater", Boiler( BoilerNum ).Name,
"Design Size Nominal Capacity [W]", tmpNomCap );
}
if ( PlantFirstSizesOkayToReport ) {
ReportSizingOutput( "Boiler:HotWater", Boiler( BoilerNum ).Name,
"Initial Design Size Nominal Capacity [W]", tmpNomCap );
}
} else { // Hard-sized with sizing data
if ( Boiler( BoilerNum ).NomCap > 0.0 && tmpNomCap > 0.0 ) {
NomCapUser = Boiler( BoilerNum ).NomCap;
if ( PlantSizesOkayToReport ) {
if ( PlantFinalSizesOkayToReport ) {
ReportSizingOutput( "Boiler:HotWater", Boiler( BoilerNum ).Name, "Design Size Nominal Capacity [W]", tmpNomCap, "User-Specified Nominal Capacity [W]", NomCapUser );
if ( DisplayExtraWarnings ) {
if ( ( std::abs( tmpNomCap - NomCapUser ) / NomCapUser ) > AutoVsHardSizingThreshold ) {
Expand All @@ -746,12 +751,12 @@ namespace Boilers {
}
}
} else {
if ( Boiler( BoilerNum ).NomCapWasAutoSized ) {
if ( Boiler( BoilerNum ).NomCapWasAutoSized && PlantFirstSizesOkayToFinalize ) {
ShowSevereError( "Autosizing of Boiler nominal capacity requires a loop Sizing:Plant object" );
ShowContinueError( "Occurs in Boiler object=" + Boiler( BoilerNum ).Name );
ErrorsFound = true;
} else { // Hard-sized with no sizing data
if ( PlantSizesOkayToReport ) {
if ( PlantFinalSizesOkayToReport ) {
if ( Boiler( BoilerNum ).NomCap > 0.0 ) {
ReportSizingOutput( "Boiler:HotWater", Boiler( BoilerNum ).Name, "User-Specified Nominal Capacity [W]", Boiler( BoilerNum ).NomCap );
}
Expand All @@ -770,13 +775,18 @@ namespace Boilers {
if ( PlantFirstSizesOkayToFinalize ) {
if ( Boiler( BoilerNum ).VolFlowRateWasAutoSized ) {
Boiler( BoilerNum ).VolFlowRate = tmpBoilerVolFlowRate;
if ( PlantSizesOkayToReport) {
ReportSizingOutput( "Boiler:HotWater", Boiler( BoilerNum ).Name, "Design Size Design Water Flow Rate [m3/s]", tmpBoilerVolFlowRate );
if ( PlantFinalSizesOkayToReport) {
ReportSizingOutput( "Boiler:HotWater", Boiler( BoilerNum ).Name,
"Design Size Design Water Flow Rate [m3/s]", tmpBoilerVolFlowRate );
}
if ( PlantFirstSizesOkayToReport) {
ReportSizingOutput( "Boiler:HotWater", Boiler( BoilerNum ).Name,
"Initial Design Size Design Water Flow Rate [m3/s]", tmpBoilerVolFlowRate );
}
} else {
if ( Boiler( BoilerNum ).VolFlowRate > 0.0 && tmpBoilerVolFlowRate > 0.0 ) {
VolFlowRateUser = Boiler( BoilerNum ).VolFlowRate;
if ( PlantSizesOkayToReport ) {
if ( PlantFinalSizesOkayToReport ) {
ReportSizingOutput( "Boiler:HotWater", Boiler( BoilerNum ).Name, "Design Size Design Water Flow Rate [m3/s]", tmpBoilerVolFlowRate, "User-Specified Design Water Flow Rate [m3/s]", VolFlowRateUser );
if ( DisplayExtraWarnings ) {
if ( ( std::abs( tmpBoilerVolFlowRate - VolFlowRateUser ) / VolFlowRateUser ) > AutoVsHardSizingThreshold ) {
Expand All @@ -793,12 +803,12 @@ namespace Boilers {
}
}
} else {
if ( Boiler( BoilerNum ).VolFlowRateWasAutoSized ) {
if ( Boiler( BoilerNum ).VolFlowRateWasAutoSized && PlantFirstSizesOkayToFinalize ) {
ShowSevereError( "Autosizing of Boiler design flow rate requires a loop Sizing:Plant object" );
ShowContinueError( "Occurs in Boiler object=" + Boiler( BoilerNum ).Name );
ErrorsFound = true;
} else { // Hard-sized with no sizing data
if ( PlantSizesOkayToReport ) {
if ( PlantFinalSizesOkayToReport ) {
if ( Boiler( BoilerNum ).VolFlowRate > 0.0 ) {
ReportSizingOutput( "Boiler:HotWater", Boiler( BoilerNum ).Name, "User-Specified Design Water Flow Rate [m3/s]", Boiler( BoilerNum ).VolFlowRate );
}
Expand All @@ -808,7 +818,7 @@ namespace Boilers {

RegisterPlantCompDesignFlow( Boiler( BoilerNum ).BoilerInletNodeNum, tmpBoilerVolFlowRate );

if ( PlantSizesOkayToReport ) {
if ( PlantFinalSizesOkayToReport ) {
//create predefined report
equipName = Boiler( BoilerNum ).Name;
PreDefTableEntry( pdchMechType, equipName, "Boiler:HotWater" );
Expand Down
Loading

7 comments on commit 5e2e584

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HVACSizingSim_CoincidentPlant (EnergyArchmage) - x86_64-MacOS-10.9-clang: Tests Failed

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HVACSizingSim_CoincidentPlant (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HVACSizingSim_CoincidentPlant (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

Build Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HVACSizingSim_CoincidentPlant (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (599 of 599 tests passed)

Build Badge Test Badge Coverage Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HVACSizingSim_CoincidentPlant (EnergyArchmage) - i386-Windows-7-VisualStudio-12: Tests Failed

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HVACSizingSim_CoincidentPlant (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1072 of 1098 tests passed)

Build Badge Test Badge Coverage Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HVACSizingSim_CoincidentPlant (EnergyArchmage) - Win64-Windows-7-VisualStudio-12: Tests Failed

Build Badge Test Badge

Please sign in to comment.