Skip to content

Commit

Permalink
Removed unused variable and parameter
Browse files Browse the repository at this point in the history
  • Loading branch information
@Nigusse
Nigusse committed May 30, 2019
1 parent 51599e7 commit 1ec83b2
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 9 deletions.
14 changes: 6 additions & 8 deletions src/EnergyPlus/EvaporativeCoolers.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4399,7 +4399,6 @@ namespace EvaporativeCoolers {

// SUBROUTINE LOCAL VARIABLE DECLARATIONS:
Real64 ZoneCoolingLoad;
Real64 MinHumRat;
Real64 CoolingLoadThreashold;
Real64 ZoneTemp;
Real64 CoolSetLowThrottle;
Expand Down Expand Up @@ -4430,15 +4429,15 @@ namespace EvaporativeCoolers {

PartLoadRatio = 1.0;
ZoneEvapUnit(UnitNum).UnitPartLoadRatio = PartLoadRatio;
CalcZoneEvapUnitOutput(UnitNum, ZoneNum, PartLoadRatio, SensibleOutputProvided, LatentOutputProvided);
CalcZoneEvapUnitOutput(UnitNum, PartLoadRatio, SensibleOutputProvided, LatentOutputProvided);

// add cycling fan calc here

} else { // not running

PartLoadRatio = 0.0;
ZoneEvapUnit(UnitNum).UnitPartLoadRatio = PartLoadRatio;
CalcZoneEvapUnitOutput(UnitNum, ZoneNum, PartLoadRatio, SensibleOutputProvided, LatentOutputProvided);
CalcZoneEvapUnitOutput(UnitNum, PartLoadRatio, SensibleOutputProvided, LatentOutputProvided);
}

} else if (SELECT_CASE_var == ZoneCoolingLoadOnOffCycling) {
Expand All @@ -4451,15 +4450,15 @@ namespace EvaporativeCoolers {

PartLoadRatio = 1.0;
ZoneEvapUnit(UnitNum).UnitPartLoadRatio = PartLoadRatio;
CalcZoneEvapUnitOutput(UnitNum, ZoneNum, PartLoadRatio, SensibleOutputProvided, LatentOutputProvided);
CalcZoneEvapUnitOutput(UnitNum, PartLoadRatio, SensibleOutputProvided, LatentOutputProvided);

// add cycling fan calc here

} else {

PartLoadRatio = 0.0;
ZoneEvapUnit(UnitNum).UnitPartLoadRatio = PartLoadRatio;
CalcZoneEvapUnitOutput(UnitNum, ZoneNum, PartLoadRatio, SensibleOutputProvided, LatentOutputProvided);
CalcZoneEvapUnitOutput(UnitNum, PartLoadRatio, SensibleOutputProvided, LatentOutputProvided);
}

} else if (SELECT_CASE_var == ZoneCoolingLoadVariableSpeedFan) {
Expand All @@ -4471,22 +4470,21 @@ namespace EvaporativeCoolers {
// determine fan speed to meet load
ControlVSEvapUnitToMeetLoad(UnitNum, ZoneNum, ZoneCoolingLoad);
// variable speed fan used fan speed ratio instead of partload ratio
CalcZoneEvapUnitOutput(UnitNum, ZoneNum, ZoneEvapUnit(UnitNum).FanSpeedRatio, SensibleOutputProvided, LatentOutputProvided);
CalcZoneEvapUnitOutput(UnitNum, ZoneEvapUnit(UnitNum).FanSpeedRatio, SensibleOutputProvided, LatentOutputProvided);

// cycling fan calc may not be needed

} else {

PartLoadRatio = 0.0;
ZoneEvapUnit(UnitNum).UnitPartLoadRatio = PartLoadRatio;
CalcZoneEvapUnitOutput(UnitNum, ZoneNum, 0.0, SensibleOutputProvided, LatentOutputProvided);
CalcZoneEvapUnitOutput(UnitNum, 0.0, SensibleOutputProvided, LatentOutputProvided);
}
}
}
}

void CalcZoneEvapUnitOutput(int const UnitNum, // unit number
int const ZoneNum, // zone number being served
Real64 const PartLoadRatio, // zone evap unit part load ratiod
Real64 &SensibleOutputProvided, // target cooling load
Real64 &LatentOutputProvided // target cooling load
Expand Down
1 change: 0 additions & 1 deletion src/EnergyPlus/EvaporativeCoolers.hh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,6 @@ namespace EvaporativeCoolers {
);

void CalcZoneEvapUnitOutput(int const UnitNum, // unit number
int const ZoneNum, // zone number being served
Real64 const PartLoadRatio, // zone evap unit part load ratiod
Real64 &SensibleOutputProvided, // sensible capacity delivered to zone
Real64 &LatentOutputProvided // Latent add/removal (kg/s), dehumid = negative
Expand Down

7 comments on commit 1ec83b2

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

166330897_Issue6707 (Nigusse) - x86_64-Linux-Ubuntu-18.04-cppcheck: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

166330897_Issue6707 (Nigusse) - x86_64-Linux-Ubuntu-18.04-custom_check: OK (7 of 7 tests passed, 0 test warnings)

Build Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

166330897_Issue6707 (Nigusse) - x86_64-MacOS-10.13-clang: OK (2410 of 2410 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

166330897_Issue6707 (Nigusse) - x86_64-Linux-Ubuntu-18.04-gcc-7.4: OK (2450 of 2450 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

166330897_Issue6707 (Nigusse) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-UnitTestsCoverage-Debug: OK (1098 of 1098 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

166330897_Issue6707 (Nigusse) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-IntegrationCoverage-Debug: OK (660 of 660 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

166330897_Issue6707 (Nigusse) - Win64-Windows-10-VisualStudio-16: OK (2410 of 2410 tests passed, 0 test warnings)

Build Badge Test Badge

Please sign in to comment.