Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates #2

Merged
merged 17 commits into from
Jan 17, 2021
Merged

updates #2

merged 17 commits into from
Jan 17, 2021

Conversation

NPWSamarasinghe
Copy link
Owner

Each pull request should address a single issue and have a meaningful title.

Description
Explain what you have changed, and why.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

---------Remove from here down in your description----------

Notes

  • Pull requests must be in English
  • If the PR solves an issue, reference it with a suitable verb and the issue number
    (e.g. fixes 12345)
  • Unsolicited pull requests will be considered, but there is no guarantee of acceptance
  • Pull requests should be from a feature branch in the contributor's fork of the repository
    to the develop branch of the project repository

michalsn and others added 17 commits January 2, 2021 10:10
test: Add a test case where the last string is a newline code when alpha_numeric_punct rule.

fix: treated as false if there is a newline at the end.

test: Add a test case where the last string is a newline code when alpha_numeric_space rule.

fix: treated as false if there is a newline at the end.

test: Add a test case where the last string is a newline code when decimal rule.

fix: treated as false if there is a newline at the end.

fix: treated as false if there is a newline at the end for alpha_numeric_space.

test: Add a test case where the last string is a newline code when numeric rule.

fix: treated as false if there is a newline at the end for numeric rule.

test: Add a test case where the last string is a newline code when decimal rule.

fix: treated as false if there is a newline at the end for alpha_dash rule.

test: Add a test case where the last string is a newline code when integer rule.

fix: treated as false if there is a newline at the end for integer rule.

fix: typo.
@NPWSamarasinghe NPWSamarasinghe merged commit 5d28010 into NPWSamarasinghe:develop Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants