forked from codeigniter4/CodeIgniter4
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates #2
Merged
NPWSamarasinghe
merged 17 commits into
NPWSamarasinghe:develop
from
codeigniter4:develop
Jan 17, 2021
Merged
updates #2
NPWSamarasinghe
merged 17 commits into
NPWSamarasinghe:develop
from
codeigniter4:develop
Jan 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test: Add a test case where the last string is a newline code when alpha_numeric_punct rule. fix: treated as false if there is a newline at the end. test: Add a test case where the last string is a newline code when alpha_numeric_space rule. fix: treated as false if there is a newline at the end. test: Add a test case where the last string is a newline code when decimal rule. fix: treated as false if there is a newline at the end. fix: treated as false if there is a newline at the end for alpha_numeric_space. test: Add a test case where the last string is a newline code when numeric rule. fix: treated as false if there is a newline at the end for numeric rule. test: Add a test case where the last string is a newline code when decimal rule. fix: treated as false if there is a newline at the end for alpha_dash rule. test: Add a test case where the last string is a newline code when integer rule. fix: treated as false if there is a newline at the end for integer rule. fix: typo.
…nThePatternMatch
Add mime type for rar files
Fix Request::withMethod()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each pull request should address a single issue and have a meaningful title.
Description
Explain what you have changed, and why.
Checklist:
---------Remove from here down in your description----------
Notes
(e.g. fixes 12345)
to the develop branch of the project repository