waf_tools/magnum: fix libdl detection #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'll merge as soon as the CI tests pass. |
|
ok if I understand correctly configure fails in CI when trying to find dartpy, with gcc only. Is this a known issue or should I investigate ? On my side building is fine with ubuntu 20.04 and 18.04 (docker out of the box, some custom install paths, gcc, python ON) |
It's not a known issue, but my other branches failed there as well (tried yesterday). So it's not related to your PR. Merging and I will investigate later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix libdl detection for magnum in waf_tools when libdl.so is found but not libdl.so.2, that was breaking the build in ubuntu18.04 at least.