Stochastic land perturbations: add roughness length over land to the perturbed variables #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndp; bugfix for tests/parm/ccpp_gsd_sar.nml.IN
…hysics for code review and testing
climbfuji
force-pushed
the
gsl_stoch_zorl
branch
from
a997634 to
ed4fa06
Compare
DomHeinzeller
approved these changes
Jan 19, 2021
…stic_physics and fv3atm
tanyasmirnova
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR and associated PRs below add the roughness length over land to the perturbed variables. They also fix a number of small bugs in fv3atm and ccpp-physics. With these, the regression tests in
rt_ccpp_dev.confpass with both Intel and GNU.Issue(s) addressed
Fixes NOAA-GSL/ccpp-physics#68.
Testing
Regression testing on Cheyenne (instead of Hera because of the data loss there) against official baselines:
rt.conf: all tests pass except the two known to have different answers (because of recent updates in gsl/develop)rt_gnu.conf: all tests pass except the two known to have different answers (because of recent updates in gsl/develop)Regression testing on Cheyenene with Intel and GNU using
rt_ccpp_dev.conf: first create, then verify - all tests pass.rt_ccpp_dev_gnu_create.log
rt_ccpp_dev_gnu_verify.log
rt_ccpp_dev_intel_create.log
rt_ccpp_dev_intel_verify.log
Dependencies
NOAA-GSL/fv3atm#70
NOAA-GSL/stochastic_physics#2